Add sync_state to all KNX YAML entities - #178526
Merged
Merged
Conversation
…text These platforms have state addresses but didn't support the `sync_state` option in YAML yet. Like in the UI schema, disabling state updates entirely is not allowed for entities having a writable group address. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable KNX state synchronization to the remaining YAML entity platforms.
Changes:
- Adds validated
sync_stateconfiguration, disallowingfalse. - Passes synchronization settings to XKNX devices.
- Updates platform tests to exercise initialization reads.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/knx/validation.py |
Adds non-false synchronization validation. |
homeassistant/components/knx/schema.py |
Extends six YAML platform schemas. |
homeassistant/components/knx/climate.py |
Forwards climate synchronization settings. |
homeassistant/components/knx/cover.py |
Forwards cover synchronization settings. |
homeassistant/components/knx/light.py |
Forwards light synchronization settings. |
homeassistant/components/knx/number.py |
Forwards number synchronization settings. |
homeassistant/components/knx/switch.py |
Forwards switch synchronization settings. |
homeassistant/components/knx/text.py |
Forwards text synchronization settings. |
tests/components/knx/test_climate.py |
Exercises climate initialization reads. |
tests/components/knx/test_cover.py |
Exercises cover initialization reads. |
tests/components/knx/test_light.py |
Exercises light initialization reads. |
tests/components/knx/test_number.py |
Exercises number initialization reads. |
tests/components/knx/test_switch.py |
Exercises switch initialization reads. |
tests/components/knx/test_text.py |
Exercises text initialization reads. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
Suppressed comments (1)
homeassistant/components/knx/validation.py:128
- Use “cannot” as one word in this validation message, and update the matching test assertion.
vol.IsTrue("Sync state can not be disabled for this platform"),
8 tasks
joostlek
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
climate, cover, light, number, switch and text
These platforms have state addresses but didn't support the
sync_stateoption in YAML yet. Like in the UI schema, disabling state updates entirely is not valid.Type of change
Additional information
sync_statehome-assistant.io#47335Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: