Closed
Conversation
From was sending the from number in an array which cannot be handled by the ClickSend system and causes a 500 error. Changed from to "hass" as from number/name can only be up to 11 characters with no special characters or spaces. Bug was introduced 6 months ago when support for multiple recipients was added.
Contributor
Contributor
Author
|
I am a developer at ClickSend and am trying to fix the code after another contributed added a bug that prevents the integration working. Is there a way to get this fixed into production as continuous-integration/travis-ci/pr is rejecting my merge and is failing for an unrelated reason. |
Member
|
You should use to the dev branch |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From was sending the from number in an array which cannot be handled by the ClickSend system and causes a 500 error. Changed from to "hass" as from number/name can only be up to 11 characters with no special characters or spaces.
Bug was introduced 6 months ago when support for multiple recipients was added.
Description:
Single line change removing a bug so that the From number in the sms sent is set to "hass" to correct sender array 500 error issue.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: