Away mode temperature fix for generic thermostat#17641
Merged
Danielhiversen merged 6 commits intohome-assistant:devfrom Oct 23, 2018
estevez-dev:dev
Merged
Away mode temperature fix for generic thermostat#17641Danielhiversen merged 6 commits intohome-assistant:devfrom estevez-dev:dev
Danielhiversen merged 6 commits intohome-assistant:devfrom
estevez-dev:dev
Conversation
Away mode temperature issue fix for generic_thermostat
Contributor
|
Hi @estevez-dev, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
houndci-bot
reviewed
Oct 20, 2018
Member
|
Could you add a test for this? |
Author
Unfortunately I am complete zero in python. It would be very nice if someone more experienced will help me with it. |
Test for fix of generic thermostat issue when away_mode was set several times in a row.
Author
|
Ok, I've added a test for setting away_mode twice. @Danielhiversen please let me know is it acceptable. |
Danielhiversen
requested changes
Oct 22, 2018
Member
Danielhiversen
left a comment
There was a problem hiding this comment.
Thanks.
Just two small details
Author
|
Done |
Member
|
Looks good. Github has some issues, so the tests are not running. |
houndci-bot
reviewed
Oct 22, 2018
Member
|
:thanks |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Away mode temperature issue fix for generic_thermostat
Related issue (if applicable): fixes #17433
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: