Add lovelace websocket get and set card#17600
Merged
balloob merged 5 commits intohome-assistant:devfrom Oct 22, 2018
Merged
Conversation
ghost
added
the
houndci-bot
reviewed
Oct 18, 2018
| error = None | ||
| try: | ||
| result = await hass.async_add_executor_job( | ||
| set_card, hass.config.path(LOVELACE_CONFIG_FILE), |
| # Do we want to return config on save? | ||
| return True | ||
|
|
||
| raise CardNotFoundError("Card with ID: {} was not found in {}.".format(card_id, fname)) |
There was a problem hiding this comment.
line too long (91 > 79 characters)
| if card.get('id') == card_id: | ||
| return object_to_yaml(card) | ||
|
|
||
| raise CardNotFoundError("Card with ID: {} was not found in {}.".format(card_id, fname)) |
There was a problem hiding this comment.
line too long (91 > 79 characters)
Member
|
Good start! Can you add a test for set card. |
bramkragten
changed the title
bramkragten
changed the title
Like !include will now give an error in the frontend.
balloob
reviewed
Oct 22, 2018
| config = load_yaml(fname) | ||
| for view in config.get('views', []): | ||
| for card in view.get('cards', []): | ||
| if card.get('id') == card_id: |
Member
There was a problem hiding this comment.
you can reverse this statement to save an indentation and make code easier to read:
if card.get('id') != card_id:
continue
balloob
reviewed
Oct 22, 2018
| card_config = yaml_to_object(card_config) | ||
| card.update(card_config) | ||
| save_yaml(fname, config) | ||
| return True |
Member
There was a problem hiding this comment.
No reason to return anything if we raise otherwise.
balloob
approved these changes
Oct 22, 2018
balloob
pushed a commit
that referenced
this pull request
Oct 23, 2018
* Add ws get, set card * lint+fix test * Add test for set * Added more tests, catch unsupported yaml constructors Like !include will now give an error in the frontend. * lint
Merged
iantrich
pushed a commit
to iantrich/home-assistant
that referenced
this pull request
Oct 27, 2018
* Add ws get, set card * lint+fix test * Add test for set * Added more tests, catch unsupported yaml constructors Like !include will now give an error in the frontend. * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: