Prefix all xiaomi_aqara events

[syssi]

Description:

It was wrong from the beginning. This integration now behaves badly by firing events not specifically identifiable.

All events are prefixed now by "xiaomi_aqara". Please update your automations:

motion -> xiaomi_aqara.motion
click -> xiaomi_aqara.click
cube_action -> xiaomi_aqara.cube_action

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7587

[Kane610]

Since you're doing breaking changes, you should fix the device types being entities but firing custom events instead of keeping states.

Entities only being exposed using custom events should be handled in the hub and not in a platform.

You can see deCONZ as one example of this.

[balloob]

@Kane610 is right, move these events to the component.

[rytilahti]

I thought I'll write also my thoughts here, too. I'm wondering what are the pros of prefixing the events like this? The events being fired will deliver the entity id and are thus identifiable already, and I'm afraid that having a variety of naming schemes for similar events leads to more confusion among users. On top of that it makes it harder to share automations and upgrade/swap hardware (e.g. instead of simply updating the entity-id, you have to change also the events). Do the pros really outweigh those cons?

[balloob]

The reason we want unique events because we haven't standardized events yet. If we want to do that, we can open an architecture issue. This hasn't been done and so platform prefixed it is.

[syssi]

We should standardize the events first. Closing this.

[balloob]

I disagree. We should rename these events first to make sure they follow our existing policy of event naming. Then we can try to standardize things.

[syssi]

I fear the breaking change.

[balloob]

Imagine that we standardize it, that the format or maybe even the intention of the events change, and we end up triggering a lot more false positive events?

[balloob]

so let's merge? 👍

[frenck]

@syssi Docs?!

[syssi]

@frenck home-assistant/home-assistant.io#7587

[frenck]

Thanks, @syssi! 👍