Skip to content

Fix HomeMatic availability detection #17341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielperna84 merged 4 commits into from
Oct 15, 2018
Merged

Fix HomeMatic availability detection #17341

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab3a50b
Fix availability detection
danielperna84 Oct 11, 2018
4b0408f
Channel 0 now obsolete
danielperna84 Oct 12, 2018
26d8c5f
Lint
danielperna84 Oct 15, 2018
fbd136c
Nicer Lint Solution
danielperna84 Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions homeassistant/components/homematic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,11 +797,8 @@ def _hm_event_callback(self, device, caller, attribute, value):
has_changed = True

# Availability has changed
if attribute == 'UNREACH':
self._available = not bool(value)
has_changed = True
elif not self.available:
self._available = False
if self.available != (not self._hmdevice.UNREACH):
self._available = not self._hmdevice.UNREACH
has_changed = True

# If it has changed data point, update HASS
Expand All @@ -811,7 +808,6 @@ def _hm_event_callback(self, device, caller, attribute, value):
def _subscribe_homematic_events(self):
"""Subscribe all required events to handle job."""
channels_to_sub = set()
channels_to_sub.add(0) # Add channel 0 for UNREACH

# Push data to channels_to_sub from hmdevice metadata
for metadata in (self._hmdevice.SENSORNODE, self._hmdevice.BINARYNODE,
Expand Down