Allow tradfri groups for new imported entries#17310
Merged
balloob merged 6 commits intohome-assistant:devfrom Oct 11, 2018
Merged
Allow tradfri groups for new imported entries#17310balloob merged 6 commits intohome-assistant:devfrom
balloob merged 6 commits intohome-assistant:devfrom
Conversation
ghost
assigned
MartinHjelmare
force-pushed
the
allow-tradfri-groups-new-imported-entries
branch
from
c1a2364 to
d412aea
Compare
balloob
reviewed
Oct 10, 2018
balloob
approved these changes
Oct 10, 2018
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
ok to merge when one comment has been addressed
2 tasks
balloob
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Clean up leftover config schema option * Allow import groups via new config yaml setup * Fix and add test * Add a test without groups for legacy import * Change default import groups to False * Fix I/O in test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable):
fixes #16992
Pull request in home-assistant.io with documentation (if applicable):
home-assistant/home-assistant.io#6664
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass