Conversation
ghost
assigned
houndci-bot
reviewed
Oct 9, 2018
| patch('homeassistant.components.mqtt.' | ||
| 'config_flow.FlowHandler.async_step_hassio', | ||
| Mock(return_value=mock_coro({"type": "abort"})) | ||
| ) as mock_mqtt:): |
There was a problem hiding this comment.
closing bracket does not match visual indentation
SyntaxError: invalid syntax
missing whitespace after ':'
| }) | ||
|
|
||
|
|
||
| async def test_hassio_discovery_startup_done(hass, aioclient_mock, |
houndci-bot
reviewed
Oct 9, 2018
houndci-bot
reviewed
Oct 9, 2018
Member
|
When can this happen? |
Member
Author
|
on 99% of our hass.io installation they load the component over the internal discovery after startup |
Member
|
Ah I see it, discovery component doesn't kick in till START event. |
balloob
pushed a commit
that referenced
this pull request
Oct 10, 2018
* Update discovery.py * Update test_discovery.py * Update test_discovery.py * Update test_discovery.py * Update test_discovery.py * Update test_discovery.py * Update test_discovery.py * Fix tests * fix lint
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fix the bug, that hassio component can startup after start and don't discovery exists requests.