Remove warning on script delay#17264
Merged
balloob merged 2 commits intohome-assistant:devfrom Oct 9, 2018
Merged
Conversation
pvizeli
reviewed
Oct 8, 2018
| self._async_listener.remove(unsub) | ||
| except ValueError: | ||
| pass | ||
|
|
pvizeli
reviewed
Oct 8, 2018
homeassistant/helpers/script.py
Outdated
| try: | ||
| self._async_listener.remove(unsub) | ||
| except ValueError: | ||
| pass |
balloob
pushed a commit
that referenced
this pull request
Oct 9, 2018
* Remove warning on script delay * Use suppress
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is another attempt at the fix in #16923.
Apparently I got confused by the naming. The
_async_remove_listener()helper actually does more than justremove()the listener. The result is (harmless) warnings about double timer unsubscribes for script delays.This reworked fix just ignores the exception that could happen if a script is turned on/off right as its timer expires.
Related issue (if applicable): fixes #17204
Example entry for
configuration.yaml(if applicable):Checklist:
tox.If the code does not interact with devices: