Skip to content

Fix upnp by adding defaults#17261

Merged
balloob merged 1 commit intohome-assistant:devfrom
StevenLooman:igd
Oct 9, 2018
Merged

Fix upnp by adding defaults#17261
balloob merged 1 commit intohome-assistant:devfrom
StevenLooman:igd

Conversation

@StevenLooman
Copy link
Copy Markdown
Contributor

Description:

Fix for #17229, settings defaults for user-input

Related issue (if applicable): fixes #17229

Pull request in home-assistant.io with documentation (if applicable): -

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Oct 8, 2018
@MartinHjelmare MartinHjelmare changed the title Add defaults, fixing #17229 Fix upnp by adding defaults Oct 8, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if defaults were supported, but they are now. 👍

@dgomes dgomes added this to the 0.80 milestone Oct 9, 2018
@balloob balloob merged commit 4455a28 into home-assistant:dev Oct 9, 2018
@ghost ghost removed the in progress label Oct 9, 2018
balloob pushed a commit that referenced this pull request Oct 9, 2018
@balloob balloob mentioned this pull request Oct 12, 2018
@StevenLooman StevenLooman deleted the igd branch October 20, 2018 14:08
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with UPnP/IGD

6 participants