Conversation
ghost
assigned
Contributor
|
As long as 8300 port is not accessible from external we should be fine, but yes, a block for all external IP access is a quick fix. |
OverloadUT
approved these changes
Oct 8, 2018
Contributor
OverloadUT
left a comment
OverloadUT
left a comment
There was a problem hiding this comment.
Spot checked for style issues or obvious logic failures, but I can't comment much on the accuracy of the implementation
balloob
added a commit
that referenced
this pull request
Oct 9, 2018
* block external IP * Update __init__.py
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I was looking for the auth issue by @awarecan to link the new webhook trigger PR #17246 when I stumbled upon #15427. I wish I had seen this earlier or that it was escalated.
Anyway, here is a PR to block all external IPs from accessing the emulated Hue APIs.
Could probably be a decorator but wanted to get this out fast.
I really hate the emulated Hue component, it's been such a source of problems.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: