SPC: Fix recorder/history graph#17220
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 7, 2018
Merged
Conversation
homeassistant
added
integration: spc
platform: alarm_control_panel.spc
small-pr
ghost
added
the
balloob
approved these changes
Oct 7, 2018
Member
|
Nice! Will include it in 0.80 |
| async def async_setup_platform(hass, config, async_add_entities, | ||
| discovery_info=None): | ||
| """Set up the SPC binary sensor.""" | ||
| if (discovery_info is None or |
Member
There was a problem hiding this comment.
We should still guard from no discovery_info.
| hass.async_create_task(discovery.async_load_platform( | ||
| hass, 'binary_sensor', DOMAIN, | ||
| {ATTR_DISCOVER_DEVICES: spc.zones.values()}, config)) | ||
| hass, 'binary_sensor', DOMAIN)) |
Member
There was a problem hiding this comment.
Send an empty dict as discovery_info.
balloob
pushed a commit
that referenced
this pull request
Oct 8, 2018
Member
|
ugh was not paying attention . will put in a quick fix Martin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Due to problems with non-serializable data passed to
async_setup_platformthe recorder component didn't want to play causing UI history graphs not to show for any entity when the SPC component was loaded.Two tests no longer considered relevant have been removed.
Related issue (if applicable): fixes #16984
Checklist:
tox. Your PR cannot be merged unless tests pass