Refactor mysensors message handling#17214
Merged
MartinHjelmare merged 4 commits intohome-assistant:devfrom Nov 4, 2018
Merged
Conversation
ghost
assigned
Member
Author
|
CC @inetAnt This should allow you to more easily handle heartbeats. Register a handler of that internal message type in the handler module. Connect an additional callback in the base mysensors entity class and the device tracker platform for node updates. |
MartinHjelmare
changed the title
MartinHjelmare
force-pushed
the
refactor-mysensors-msg-handling
branch
from
4309771 to
cf3c015
Compare
Member
Author
|
@inetAnt I've now included node callbacks and a node update helper in the handler module. So handling hearbeats should be just registering a new handler and calling the node update handler helper, besides adding hearbeats to device state attributes. This PR is now tested, so it's ready for review. |
* Add handler module and register handlers per message type or message sub-type. This will allow easier extension of message handling in the future. * Move some common functions to a helpers module.
* Fix bug in message modification.
MartinHjelmare
force-pushed
the
refactor-mysensors-msg-handling
branch
from
cf3c015 to
2dfb015
Compare
Member
Author
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests pass