Fix aliases support for RFLink sensors#17190
Conversation
|
Thanks for the PR. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
See the tuya component for how to use our dispatch helper.
| if aliases: | ||
| for _id in aliases: | ||
| hass.data[DATA_ENTITY_LOOKUP][ | ||
| EVENT_KEY_SENSOR][_id].append(device) |
There was a problem hiding this comment.
This should be refactored to use our dispatch helper instead. We should not store entities in a shared dictionary in hass.data. Entities should only be accessed directly from within their own platform.
|
@emontnemery & @javicalle Guys, as I can see you are more or less familiar with rflink component, and I' like to ask for some info/help. I run Hass.io 0.83.2 on RPi3 with Arduino Mega flashed with RFLink V1.1 R48
Sorry for posting my questions here as was unable to get help [elsewhere](url |
|
Please open an issue if you suspect a bug. If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
Description:
Fix aliases support for RFLink sensors
Related issue (if applicable): fixes #16790 and fixes #16703
Checklist:
tox. Your PR cannot be merged unless tests pass