Address future error in RepairFlow#171156
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the async_step_init signature in the Anthropic repairs flow to accept None for user_input, matching the base class contract and preventing an AttributeError when called without input.
Changes:
- Updated
user_inputparameter type todict[str, str] | None. - Added a
Noneguard before accessinguser_input.get(CONF_CHAT_MODEL).
Contributor
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
|
Thank you for the fix! Yes, you are right, we currently rely on |
Shulyaka
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
DataEntryFlows such asRepairFlowshould check ifuser_inputisNoneinasync_step_*to see if the user has submitted a form. TheModelDeprecatedRepairFlowdoes not check forNone. The reason this works in the current dev branch is because theRepairsFlowManagerwould pass (rather inadvertently){"issue_id": <issue_id>}asinit_datawhich becomesuser_inputinasync_step_init. This will break when #165091 is merged.Type of change
Additional information
next_flowto Repair Flows #165091Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: