Skip to content

Address future error in RepairFlow#171156

Merged
Shulyaka merged 1 commit into
home-assistant:devfrom
iluvdata:athropic-repair-issue
May 19, 2026
Merged

Address future error in RepairFlow#171156
Shulyaka merged 1 commit into
home-assistant:devfrom
iluvdata:athropic-repair-issue

Conversation

@iluvdata
Copy link
Copy Markdown
Contributor

Proposed change

DataEntryFlows such as RepairFlow should check if user_input is None in async_step_* to see if the user has submitted a form. The ModelDeprecatedRepairFlow does not check for None. The reason this works in the current dev branch is because the RepairsFlowManager would pass (rather inadvertently) {"issue_id": <issue_id>} as init_data which becomes user_input in async_step_init. This will break when #165091 is merged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to PR: Add next_flow to Repair Flows #165091
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Copilot AI review requested due to automatic review settings May 18, 2026 22:35
@iluvdata iluvdata requested a review from Shulyaka as a code owner May 18, 2026 22:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the async_step_init signature in the Anthropic repairs flow to accept None for user_input, matching the base class contract and preventing an AttributeError when called without input.

Changes:

  • Updated user_input parameter type to dict[str, str] | None.
  • Added a None guard before accessing user_input.get(CONF_CHAT_MODEL).

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration (anthropic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of anthropic can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign anthropic Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown

@davidlang42 davidlang42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shulyaka
Copy link
Copy Markdown
Contributor

Thank you for the fix! Yes, you are right, we currently rely on issue_id to be present.

@Shulyaka Shulyaka merged commit 2dae262 into home-assistant:dev May 19, 2026
33 checks passed
@iluvdata iluvdata deleted the athropic-repair-issue branch May 19, 2026 12:35
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants