Fix Verisure alarm crash when cloud rejects arm/disarm command#171024
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to make Verisure alarm arm/disarm failures user-facing by raising a translated Home Assistant error instead of surfacing a raw AttributeError.
Changes:
- Adds a translated exception message for failed alarm state changes.
- Adds a
HomeAssistantErrorguard when the Verisure arm/disarm command response is missing expected data.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/verisure/alarm_control_panel.py |
Adds error handling for rejected/malformed Verisure alarm state command responses. |
homeassistant/components/verisure/strings.json |
Adds the translated error message used by the new exception. |
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When the Verisure cloud rejects an
alarm_arm_*oralarm_disarmcall (wrong PIN, wrong PIN length, rate-limited account), the API returnsNone. The code then triesarm_state["data"]on theNonereturn value, crashing with:This makes ordinary user mistakes (mistyped PIN, too few digits) appear as an integration crash rather than clear feedback.
The fix checks for
Nonebefore accessing the response and raises a translatedHomeAssistantErrorso the user sees a proper error message in the UI.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: