Skip to content

Fix Verisure alarm crash when cloud rejects arm/disarm command#171024

Merged
balloob merged 2 commits into
devfrom
frenck-2026-0585
May 17, 2026
Merged

Fix Verisure alarm crash when cloud rejects arm/disarm command#171024
balloob merged 2 commits into
devfrom
frenck-2026-0585

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Breaking change

Proposed change

When the Verisure cloud rejects an alarm_arm_* or alarm_disarm call (wrong PIN, wrong PIN length, rate-limited account), the API returns None. The code then tries arm_state["data"] on the None return value, crashing with:

AttributeError: 'NoneType' object has no attribute 'get'

This makes ordinary user mistakes (mistyped PIN, too few digits) appear as an integration crash rather than clear feedback.

The fix checks for None before accessing the response and raises a translated HomeAssistantError so the user sees a proper error message in the UI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 20:06
@frenck frenck added this to the 2026.5.3 milestone May 17, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to make Verisure alarm arm/disarm failures user-facing by raising a translated Home Assistant error instead of surfacing a raw AttributeError.

Changes:

  • Adds a translated exception message for failed alarm state changes.
  • Adds a HomeAssistantError guard when the Verisure arm/disarm command response is missing expected data.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
homeassistant/components/verisure/alarm_control_panel.py Adds error handling for rejected/malformed Verisure alarm state command responses.
homeassistant/components/verisure/strings.json Adds the translated error message used by the new exception.

Comment thread homeassistant/components/verisure/alarm_control_panel.py
Comment thread homeassistant/components/verisure/alarm_control_panel.py
Comment thread homeassistant/components/verisure/strings.json Outdated
@balloob balloob merged commit 1c105a5 into dev May 17, 2026
32 of 33 checks passed
@balloob balloob deleted the frenck-2026-0585 branch May 17, 2026 20:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verisure: AttributeError 'NoneType' object has no attribute 'get' when alarm cloud rejects arm/disarm

3 participants