Fix shorthand template conditions in choose blocks crashing all automations#171018
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent shorthand template conditions inside nested condition blocks from crashing automation validation.
Changes:
- Allows
async_validate_condition_configto accept raw string shorthand conditions. - Converts raw shorthand strings into template condition dictionaries.
- Adds a regression test for shorthand template conditions inside an
orblock.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/helpers/condition.py |
Adds defensive handling for raw shorthand template condition strings. |
tests/helpers/test_condition.py |
Adds coverage for validating a shorthand template condition nested in an or condition. |
…emplate The previous fix stored value_template as a plain string, which crashes at runtime because async_template calls .async_render_to_info() on it. Also extend the test to actually evaluate the condition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When a shorthand template condition (bare Jinja2 string) is used inside a
choose,or,and, ornotblock,async_validate_condition_configcrashes withTypeError: string indices must be integers, not 'str'because it expects a dict but receives a raw string.The schema's
dynamic_template_conditionnormally converts bare template strings to{condition: "template", value_template: "..."}dicts, but this conversion doesn't run whenasync_validate_condition_configrecurses into nested condition lists. One malformed condition in one automation takes down all automations globally.The fix handles the bare string case defensively in
async_validate_condition_configby converting it to the proper template condition dict before accessing dict keys.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: