Skip to content

Handle Daikin connection errors gracefully in coordinator#171017

Merged
balloob merged 1 commit into
devfrom
frenck-2026-0582
May 17, 2026
Merged

Handle Daikin connection errors gracefully in coordinator#171017
balloob merged 1 commit into
devfrom
frenck-2026-0582

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Proposed change

When a Daikin device is powered off or unreachable, update_status() raises DaikinException which propagates as an unhandled exception. The coordinator logs a full traceback every polling interval (~83 seconds), flooding the logs indefinitely until the device comes back online.

The fix catches DaikinException and raises UpdateFailed with a translated error message. The coordinator then handles this gracefully: marks the entity as unavailable, logs at debug level, and retries on the next interval without log spam.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 19:11
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Catches DaikinException from pydaikin's update_status() in the coordinator and re-raises as a translated UpdateFailed, so the coordinator marks entities unavailable and stops emitting tracebacks every poll when a Daikin device is unreachable.

Changes:

  • Wrap update_status() in a try/except DaikinException and raise UpdateFailed with a translation key.
  • Add a new error_communicating exception message to strings.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/daikin/coordinator.py Catch DaikinException and convert to translated UpdateFailed.
homeassistant/components/daikin/strings.json Add error_communicating exception message used by the coordinator.

@balloob balloob merged commit 03ea95d into dev May 17, 2026
33 of 34 checks passed
@balloob balloob deleted the frenck-2026-0582 branch May 17, 2026 20:44
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daikin integration fills log with errors when device powered off

3 participants