Handle Daikin connection errors gracefully in coordinator#171017
Merged
Conversation
Contributor
|
Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Catches DaikinException from pydaikin's update_status() in the coordinator and re-raises as a translated UpdateFailed, so the coordinator marks entities unavailable and stops emitting tracebacks every poll when a Daikin device is unreachable.
Changes:
- Wrap
update_status()in atry/except DaikinExceptionand raiseUpdateFailedwith a translation key. - Add a new
error_communicatingexception message tostrings.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/daikin/coordinator.py | Catch DaikinException and convert to translated UpdateFailed. |
| homeassistant/components/daikin/strings.json | Add error_communicating exception message used by the coordinator. |
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When a Daikin device is powered off or unreachable,
update_status()raisesDaikinExceptionwhich propagates as an unhandled exception. The coordinator logs a full traceback every polling interval (~83 seconds), flooding the logs indefinitely until the device comes back online.The fix catches
DaikinExceptionand raisesUpdateFailedwith a translated error message. The coordinator then handles this gracefully: marks the entity as unavailable, logs at debug level, and retries on the next interval without log spam.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: