Skip to content

Fix manual alarm panel crash on restore with invalid state#171016

Merged
balloob merged 1 commit into
devfrom
frenck-2026-0581
May 17, 2026
Merged

Fix manual alarm panel crash on restore with invalid state#171016
balloob merged 1 commit into
devfrom
frenck-2026-0581

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Breaking change

Proposed change

The manual alarm control panel crashes on every startup when the stored state is not a valid AlarmControlPanelState value (e.g. "unknown", which can happen if the state was set via developer tools). AlarmControlPanelState("unknown") raises ValueError during async_added_to_hass, permanently preventing the entity from loading. There is no way to recover without manually editing core.restore_state.

The fix catches the ValueError and skips the invalid restored state, letting the entity initialize with its default state (disarmed).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a crash in the manual alarm control panel when a previously stored state is not a valid AlarmControlPanelState (e.g. "unknown"), which made the entity fail to load on every restart.

Changes:

  • Wrap restored-state conversion in try/except ValueError and bail out, letting the entity initialize with its default state.
  • Add a regression test that restores "unknown" and asserts the entity comes up as disarmed.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/manual/alarm_control_panel.py Catch ValueError from AlarmControlPanelState(...) during restore.
tests/components/manual/test_alarm_control_panel.py New test verifying setup succeeds with an invalid restored state.

@frenck frenck added this to the 2026.5.3 milestone May 17, 2026
@balloob balloob merged commit d071162 into dev May 17, 2026
34 checks passed
@balloob balloob deleted the frenck-2026-0581 branch May 17, 2026 20:44
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alarm Control Panel "Manual": Error with not allowed states and fail entity creation on every start process

3 participants