Fix manual alarm panel crash on restore with invalid state#171016
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the manual alarm control panel when a previously stored state is not a valid AlarmControlPanelState (e.g. "unknown"), which made the entity fail to load on every restart.
Changes:
- Wrap restored-state conversion in
try/except ValueErrorand bail out, letting the entity initialize with its default state. - Add a regression test that restores
"unknown"and asserts the entity comes up asdisarmed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/manual/alarm_control_panel.py | Catch ValueError from AlarmControlPanelState(...) during restore. |
| tests/components/manual/test_alarm_control_panel.py | New test verifying setup succeeds with an invalid restored state. |
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The manual alarm control panel crashes on every startup when the stored state is not a valid
AlarmControlPanelStatevalue (e.g."unknown", which can happen if the state was set via developer tools).AlarmControlPanelState("unknown")raisesValueErrorduringasync_added_to_hass, permanently preventing the entity from loading. There is no way to recover without manually editingcore.restore_state.The fix catches the
ValueErrorand skips the invalid restored state, letting the entity initialize with its default state (disarmed).Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: