Skip to content

Fix Control4 climate crash when humidity is 'Undefined'#171015

Merged
balloob merged 1 commit into
devfrom
frenck-2026-0580
May 17, 2026
Merged

Fix Control4 climate crash when humidity is 'Undefined'#171015
balloob merged 1 commit into
devfrom
frenck-2026-0580

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Breaking change

Proposed change

Control4 thermostats without a humidity sensor return the string "Undefined" for the HUMIDITY variable. The current_humidity property only guards against None, so int("Undefined") raises ValueError, making all climate entities permanently unavailable. The error repeats every polling cycle so entities never recover.

The fix wraps the conversion in a try/except to handle non-numeric values gracefully, returning None (unknown humidity).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 18:43
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @lawtancool, @davidrecordon, mind taking a look at this pull request as it has been labeled with an integration (control4) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of control4 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign control4 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Control4 climate integration so thermostats reporting non-numeric humidity values such as "Undefined" no longer crash entity setup.

Changes:

  • Handles invalid humidity conversions by returning None.
  • Adds regression coverage for "Undefined" humidity values.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/control4/climate.py Catches invalid humidity conversion errors and treats them as unknown humidity.
tests/components/control4/test_climate.py Adds a regression test covering Control4 thermostats that report "Undefined" humidity.

@balloob balloob merged commit 6a5faf2 into dev May 17, 2026
34 checks passed
@balloob balloob deleted the frenck-2026-0580 branch May 17, 2026 20:45
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control4 climate entities permanently unavailable: ValueError in current_humidity when HUMIDITY variable is "Undefined"

3 participants