Fix Control4 climate crash when humidity is 'Undefined'#171015
Merged
Conversation
Contributor
|
Hey there @lawtancool, @davidrecordon, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Control4 climate integration so thermostats reporting non-numeric humidity values such as "Undefined" no longer crash entity setup.
Changes:
- Handles invalid humidity conversions by returning
None. - Adds regression coverage for
"Undefined"humidity values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/control4/climate.py |
Catches invalid humidity conversion errors and treats them as unknown humidity. |
tests/components/control4/test_climate.py |
Adds a regression test covering Control4 thermostats that report "Undefined" humidity. |
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Control4 thermostats without a humidity sensor return the string
"Undefined"for theHUMIDITYvariable. Thecurrent_humidityproperty only guards againstNone, soint("Undefined")raisesValueError, making all climate entities permanently unavailable. The error repeats every polling cycle so entities never recover.The fix wraps the conversion in a try/except to handle non-numeric values gracefully, returning
None(unknown humidity).Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: