Fix SleepIQ timer units: seconds should be minutes for core climate and foot warmer#171013
Merged
Conversation
Contributor
|
Hey there @mfugate1, @kbickar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect unit of measurement for SleepIQ timer number entities. Core Climate Timer was declared in seconds but actual values are in minutes; Foot Warming Timer had no unit at all. Both are corrected to UnitOfTime.MINUTES and the foot warmer gets NumberDeviceClass.DURATION for consistency.
Changes:
- Set
native_unit_of_measurement=UnitOfTime.MINUTESand addNumberDeviceClass.DURATIONfor the foot warming timer entity description. - Change core climate timer's unit from
SECONDStoMINUTES. - Update tests to assert
ATTR_UNIT_OF_MEASUREMENT == UnitOfTime.MINUTESfor both timers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/sleepiq/number.py | Corrects unit to minutes for both timer entities and adds duration device class to foot warmer. |
| tests/components/sleepiq/test_number.py | Adds assertions verifying the corrected unit of measurement. |
kbickar
approved these changes
May 17, 2026
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The SleepIQ integration reports wrong units for two timer entities:
UnitOfTime.SECONDSbut values are in minutes (0-600, step 30). Setting "30s" actually runs for 30 minutes.Both are changed to
UnitOfTime.MINUTESand the foot warmer also getsNumberDeviceClass.DURATIONadded for consistency with the core climate timer.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: