Fix Growatt mix device IndexError when chart data is empty#171012
Merged
Conversation
Contributor
|
Hey there @johanzander, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the Growatt Server integration’s Mix device coordinator when chartData is empty by avoiding indexing into an empty list during last-update timestamp calculation.
Changes:
- Guard Mix
lastdataupdatecalculation so emptychartDatano longer raisesIndexError. - Add a regression test that sets up a Mix device with empty
chartData.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/growatt_server/coordinator.py |
Adds an if sorted_keys: guard before reading sorted_keys[-1] to prevent IndexError on empty chart data. |
tests/components/growatt_server/test_sensor.py |
Adds a test covering Mix devices returning empty chartData during Classic API setup. |
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The Growatt Server coordinator crashes with
IndexError: list index out of rangewhen a mix device returns empty chart data. This happens becausesorted_keys[-1]is accessed without checking if the list is empty.The fix guards the timestamp calculation with an
if sorted_keys:check, skipping thelastdataupdatefield when no chart data is available.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: