Skip to content

Fix Growatt mix device IndexError when chart data is empty#171012

Merged
balloob merged 1 commit into
devfrom
frenck-2026-0578
May 17, 2026
Merged

Fix Growatt mix device IndexError when chart data is empty#171012
balloob merged 1 commit into
devfrom
frenck-2026-0578

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Proposed change

The Growatt Server coordinator crashes with IndexError: list index out of range when a mix device returns empty chart data. This happens because sorted_keys[-1] is accessed without checking if the list is empty.

The fix guards the timestamp calculation with an if sorted_keys: check, skipping the lastdataupdate field when no chart data is available.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes "list index out of range" #157141
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 18:18
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @johanzander, mind taking a look at this pull request as it has been labeled with an integration (growatt_server) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of growatt_server can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign growatt_server Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a crash in the Growatt Server integration’s Mix device coordinator when chartData is empty by avoiding indexing into an empty list during last-update timestamp calculation.

Changes:

  • Guard Mix lastdataupdate calculation so empty chartData no longer raises IndexError.
  • Add a regression test that sets up a Mix device with empty chartData.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/growatt_server/coordinator.py Adds an if sorted_keys: guard before reading sorted_keys[-1] to prevent IndexError on empty chart data.
tests/components/growatt_server/test_sensor.py Adds a test covering Mix devices returning empty chartData during Classic API setup.

Comment thread tests/components/growatt_server/test_sensor.py
Comment thread tests/components/growatt_server/test_sensor.py
@frenck frenck added this to the 2026.5.3 milestone May 17, 2026
@balloob balloob merged commit c90017d into dev May 17, 2026
34 checks passed
@balloob balloob deleted the frenck-2026-0578 branch May 17, 2026 20:48
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"list index out of range"

3 participants