Fix time trigger crash when using entity_id dict format without offset#171006
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the time trigger when at is configured using the dict/entity_id form without an offset, ensuring dict entries are handled consistently with the schema (where offset is optional).
Changes:
- Treat all dict-form
atentries as entity-based triggers (offset defaults totimedelta(0)). - Add a regression test covering dict-form
atwithout anoffset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/homeassistant/triggers/time.py |
Fix dict handling in the runtime trigger setup to avoid falling through to the datetime.time branch. |
tests/components/homeassistant/triggers/test_time.py |
Add regression coverage for at: { entity_id: ... } without offset. |
Comments suppressed due to low confidence (1)
homeassistant/components/homeassistant/triggers/time.py:275
- Use direct key access for
CONF_ENTITY_IDsince the schema requires it, so invalid dict entries fail fast instead of silently defaulting to an empty entity_id.
# entity with offset
entity_id: str = at_time.get(CONF_ENTITY_ID, "")
offset: timedelta = at_time.get(CONF_OFFSET, timedelta(0))
update_entity_trigger(
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When a time trigger uses the dict format with
entity_idbut withoutoffset:The trigger crashes with
AttributeError: 'NodeDictClass' object has no attribute 'hour'. This happens because the runtime code only handles dicts whenoffsetis present (isinstance(at_time, dict) and CONF_OFFSET in at_time), even though the schema correctly declaresoffsetas optional. Whenoffsetis missing, the dict falls through to thedatetime.timebranch which tries to access.houron it.The fix removes the
CONF_OFFSET in at_timeguard so all entity_id dicts are handled correctly. The offset already defaults totimedelta(0)via.get().Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: