Load template extensions by class to prevent import deadlock#170995
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a startup deadlock in the template integration by avoiding Jinja2 runtime imports of Home Assistant’s template extensions, which could deadlock when multiple threads create TemplateEnvironment instances concurrently.
Changes:
- Import Home Assistant template extension classes at module import time.
- Register Home Assistant extensions with
TemplateEnvironment.add_extension()by passing the extension classes directly instead of import-path strings.
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The template integration fails to load on startup with a
DeadlockErrorin theMathExtensionJinja2 extension. This happens because template extensions are registered by import path string (e.g.,"homeassistant.helpers.template.extensions.MathExtension"), which causes Jinja2 to callimport_module()at runtime. When multiple threads create aTemplateEnvironmentsimultaneously during startup, the Python import lock deadlocks.This changes the extension loading to import the classes at module level and pass them directly to
add_extension(), avoiding runtime imports entirely. The existingjinja2.extextensions remain as strings since those are external and always pre-loaded.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: