Skip to content

Prevent Google Assistant entity sync from blocking startup#170991

Merged
balloob merged 3 commits into
devfrom
frenck-2026-0566
May 17, 2026
Merged

Prevent Google Assistant entity sync from blocking startup#170991
balloob merged 3 commits into
devfrom
frenck-2026-0566

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 17, 2026

Breaking change

Proposed change

The Google Assistant integration syncs entities to Google's Homegraph API during HA startup using async_at_start. This makes HTTP requests to Google's servers, and when those are slow or unresponsive, it blocks the entire startup phase - preventing other integrations and add-ons from loading for minutes.

This changes the sync to use async_at_started instead, which defers the sync until after HA has fully started. The entity sync still happens automatically, just without blocking other integrations from starting.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (google_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR defers Google Assistant Homegraph entity sync until after Home Assistant reaches the started state, avoiding startup delays caused by slow external HTTP requests.

Changes:

  • Replaces the startup callback from async_at_start to async_at_started.
  • Keeps automatic Google Assistant entity sync behavior, but moves it out of the startup wait path.

Comment thread homeassistant/components/google_assistant/helpers.py
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@frenck frenck marked this pull request as draft May 17, 2026 16:59
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 17, 2026 17:01
@frenck frenck added this to the 2026.5.3 milestone May 17, 2026
@frenck frenck marked this pull request as ready for review May 17, 2026 17:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@balloob balloob merged commit ee83a14 into dev May 17, 2026
49 checks passed
@balloob balloob deleted the frenck-2026-0566 branch May 17, 2026 21:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Something is blocking Home Assistant from wrapping up the start up phase: AbstractConfig.async_initialize.<locals>.sync_google

3 participants