Fix is_closed state for SlidingDiscreteGateWithPedestrianPosition covers in Overkiz #170913
Merged
iMicknl merged 2 commits intoMay 16, 2026
Conversation
…n Overkiz The SlidingDiscreteGateWithPedestrianPosition widget reports core:OpenClosedPedestrianState instead of core:OpenClosedState. Without a dedicated override, it falls through to the UIClass.GATE default which looks for core:OpenClosedState—a state this device does not have—resulting in is_closed always being None. Fixes home-assistant#170259
…discrete-gate-pedestrian-position
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect is_closed reporting for Overkiz SlidingDiscreteGateWithPedestrianPosition covers by applying a widget-specific override so the entity reads core:OpenClosedPedestrianState (instead of falling back to the UIClass.GATE default core:OpenClosedState).
Changes:
- Add a
UIWidget.SLIDING_DISCRETE_GATE_WITH_PEDESTRIAN_POSITIONcover description override to useOverkizState.CORE_OPEN_CLOSED_PEDESTRIANforis_closed. - Extend Overkiz cover service-action tests to cover the sliding discrete gate device.
- Add a real-device fixture entry (Somfy Elixo 3S io) and update snapshots impacted by the new fixture device/entities.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/overkiz/cover.py | Adds widget-level cover description override so is_closed reads the correct Overkiz state for sliding discrete gates with pedestrian position. |
| tests/components/overkiz/test_cover.py | Adds a sliding gate fixture and includes it in cover open/close/stop service-action coverage. |
| tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json | Adds fixture data for an io:SlidingDiscreteGateOpenerIOComponent using SlidingDiscreteGateWithPedestrianPosition. |
| tests/components/overkiz/snapshots/test_cover.ambr | Updates snapshot to include the new cover.sliding_gate entity/state (including is_closed). |
| tests/components/overkiz/snapshots/test_button.ambr | Updates snapshot to include the new identify button entity created for the added fixture device. |
zweckj
approved these changes
May 16, 2026
Copilot AI
pushed a commit
to AlCalzone/homeassistant-core
that referenced
this pull request
May 17, 2026
…ers in Overkiz (home-assistant#170913) Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The #141330 refactor caused unintended side effects for the SlidingDiscreteGateWithPedestrianPosition cover.
Add a widget override for SlidingDiscreteGateWithPedestrianPosition so it reads core:OpenClosedPedestrianState instead of falling through to the UIClass.GATE default (core:OpenClosedState), which this device does not report.
Also adds a fixture and test coverage for the io:SlidingDiscreteGateOpenerIOComponent device (Somfy Elixo 3S io).
Fixes #170259
Type of change
Additional information
is_closedstate is unknown for Gate/SlidingDiscreteGateWithPedestrianPosition after 2026.5.1 in Overkiz #170259Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: