Add tilt controls for UpDownSheerScreen in Overkiz#170563
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
Bot
added
cla-needed
has-tests
integration: overkiz
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @iMicknl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for the Overkiz UpDownSheerScreen RTS cover device by registering a new cover description and adding corresponding test coverage and fixtures.
Changes:
- Register a new
OverkizCoverDescriptionforUP_DOWN_SHEER_SCREENmirroring the existing UpDownVenetianBlind tilt behavior. - Add a fixture JSON simulating a Somfy Connexoon RTS setup that includes an UpDownSheerScreen device.
- Extend
test_cover.pywith service action parametrizations and a tilt feature test for the new device type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/overkiz/cover.py | Adds an OverkizCoverDescription entry for UP_DOWN_SHEER_SCREEN. |
| tests/components/overkiz/fixtures/setup/cloud_somfy_connexoon_rts_asia_with_sheer_screen.json | New fixture containing a Somfy RTS setup including a sheer screen device. |
| tests/components/overkiz/test_cover.py | Adds service action and tilt feature tests for the new sheer screen device. |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
CLA signed |
|
Updated the PR with the fixture formatting fix ( Local verification on my side:
The CI rerun is in progress. The only non-code blocker I can see is |
|
Thanks for your contribution! Have you tested the fix locally? And can you please include the original pull request template. I will review later this week, but at a quick glance, the supported features test doesn't seem necessary as this is part of the snapshot already. |
|
Yes, I have tested this locally on my blinds as a custom integration |
erwindouna
left a comment
erwindouna
left a comment
There was a problem hiding this comment.
Please restore the PR template, before a review can continue. :)
iMicknl
left a comment
iMicknl
left a comment
There was a problem hiding this comment.
Thanks! Looks good. Could you add your device to an existing fixture? (e.g. one of the RTS fixtures). We try to limit the amount of new fixture files for cover entities.
|
Done.
Latest commit: |
iMicknl
changed the title
iMicknl
left a comment
iMicknl
left a comment
There was a problem hiding this comment.
Could you merge in the latest dev branch and resolve prek/pre-commit? There have been some changes in how line length is handled, and merging this PR will break CI.
…0563) Co-authored-by: Mick Vleeshouwer <mick@imick.nl> Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Breaking change
Proposed change
Add support for tilt commands on Overkiz RTS sheer screens (
UIWidget.UP_DOWN_SHEER_SCREEN).This mirrors the existing RTS venetian blind override and maps the sheer screen tilt actions to
tiltPositive/tiltNegative, which enables Home Assistant's tilt open/close services for this widget.The PR also adds fixture coverage for a real
rts:SheerBlindRTSComponentsetup and extends the service tests with the new widget.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: