Bump pyprusalink to 3.0.0 by heikkih · Pull Request #170480 · home-assistant/core

heikkih · 2026-05-13T11:43:06Z

Proposed change

This PR is intentionally scoped to a minimal dependency bump for PrusaLink.

Included scope:

Bump pyprusalink to 3.0.0.
Apply only compatibility updates required for Home Assistant to work with the updated upstream API/typing.
Include minimal cast() adjustments required by the stricter typing surface in pyprusalink 3.0.0.

Out of scope:

Broader job state semantics (unknown vs unavailable) are intentionally deferred and will be handled in a separate follow-up PR after this bump is merged.
Test updates and additional cleanup/refactors are intentionally deferred to a separate follow-up PR to keep this dependency bump minimal.

Dependency reference:

pyprusalink 2.2.0 -> 3.0.0
Release notes: https://github.com/home-assistant-libs/pyprusalink/releases/tag/3.0.0
Relevant PRs in pyprusalink 3.0.0:

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Checklist

I understand the code I am submitting and can explain how it works.
Local tests pass. Your PR cannot be merged unless tests pass
The code has been formatted using Ruff (ruff format homeassistant tests)
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

Copilot

Pull request overview

This PR bumps the PrusaLink integration’s pyprusalink dependency to 3.0.0 and updates the integration/test code to accommodate the library’s breaking change where get_job() can now return None.

Changes:

Bump pyprusalink to 3.0.0 across the integration manifest and generated requirements pins.
Update the PrusaLink coordinators/entities to correctly handle JobInfo | None payloads from the job endpoint.
Align sensors and tests with the new idle-job behavior and stricter typing introduced by pyprusalink’s py.typed.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`homeassistant/components/prusalink/manifest.json`	Bumps integration requirement pin to `pyprusalink==3.0.0`.
`requirements_all.txt`	Updates generated dependency pin for `pyprusalink`.
`requirements_test_all.txt`	Updates generated test dependency pin for `pyprusalink`.
`homeassistant/components/prusalink/coordinator.py`	Makes the job coordinator nullable (`JobInfo
`homeassistant/components/prusalink/entity.py`	Prevents `available_fn` evaluation when coordinator data is `None` (avoids idle-job crashes).
`homeassistant/components/prusalink/sensor.py`	Updates sensor value/availability logic and adds typing workarounds for stricter upstream types.
`tests/components/prusalink/conftest.py`	Adjusts job API idle fixture to return `None` (matching `pyprusalink>=3.0.0`).

Follow-up to home-assistant#170480, addressing the two `# type: ignore` comments that PR added to the `job.filename` and `job.finish` sensors. Both lambdas are guarded at runtime by `available_fn` (verifying `data["file"]` and `data["time_remaining"]` are not None respectively), but mypy doesn't follow the guarantee from `available_fn` into `value_fn`. Switch to the inner-cast pattern already used on the `printer.telemetry.material` sensor: - `job.filename`: `cast(JobFilePrint, data["file"])["display_name"]` narrows `JobFilePrint | None` so the index is type-safe. - `job.finish`: `cast(int, data["time_remaining"])` narrows `int | None` so it can be passed to `timedelta(seconds=...)`. Runtime behaviour is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

home-assistant · 2026-05-13T16:39:24Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Follow-up to home-assistant#170480, addressing the two `# type: ignore` comments that PR added to the `job.filename` and `job.finish` sensors. Both lambdas are guarded at runtime by `available_fn` (verifying `data["file"]` and `data["time_remaining"]` are not None respectively), but mypy doesn't follow the guarantee from `available_fn` into `value_fn`. Switch to the inner-cast pattern already used on the `printer.telemetry.material` sensor: - `job.filename`: `cast(JobFilePrint, data["file"])["display_name"]` narrows `JobFilePrint | None` so the index is type-safe. - `job.finish`: `cast(int, data["time_remaining"])` narrows `int | None` so it can be passed to `timedelta(seconds=...)`. Runtime behaviour is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

heikkih · 2026-05-21T11:25:36Z

I've cleaned this up to handle the version-bump in a minimal way.

The following will be handled in followup-PRs. Builds on this, so they will be opened when this one is merged:

enhanced test-coverage
Job-state-semantics (unknown instead of unavailable) - Breaking change
other cleanups and refactors.

Ready for review.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

+def mock_job_api_idle() -> Generator[None]:
+    """Mock PrusaLink job API having no job.
+
+    pyprusalink >= 3.0.0 returns `None` from `get_job()` on HTTP 204 when
+    no job is running, rather than an empty dict as in 2.x.
+    """
+    with patch("pyprusalink.PrusaLink.get_job", return_value=None):
+        yield None


erwindouna

Thanks for the changes @heikkih. Please elaborate what's related to the dependency bump and what's not. All the work that's not related to the bump, then please split that off from this PR and create separate PRs. :)

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

heikkih · 2026-05-21T17:44:14Z

Thanks for the review @erwindouna

My local venv was pointing at the older pyprusalink 2.2.0 due to parallell work in a different branch, so sorry for the noise earlier.

I've updated and gone through all changes manually. All changes are now relevant to the 3.0.0-bump, specifically the tighter typing in it, hence the need for the casts for now. I will handle these better (with some refactoring) in a follow-up PR, but now it is as minimal as I can get it, while still working correctly and passing all QA-jobs :)

I'll set this as ready for review now.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

PR seem to be cut down

Copilot AI review requested due to automatic review settings May 13, 2026 11:43

home-assistant Bot added cla-signed code-quality dependency Pull requests marked as a dependency upgrade has-tests integration: prusalink Quality Scale: No score labels May 13, 2026

Copilot started reviewing on behalf of heikkih May 13, 2026 11:43 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread tests/components/prusalink/conftest.py

Comment thread homeassistant/components/prusalink/sensor.py

Comment thread homeassistant/components/prusalink/sensor.py Outdated

Comment thread homeassistant/components/prusalink/sensor.py Outdated

heikkih mentioned this pull request May 13, 2026

prusalink: tighten typing on job.filename and job.finish sensors #170481

Closed

7 tasks

heikkih marked this pull request as draft May 13, 2026 11:51

heikkih marked this pull request as ready for review May 13, 2026 12:00

Copilot AI review requested due to automatic review settings May 13, 2026 12:00

Copilot started reviewing on behalf of heikkih May 13, 2026 12:01 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/coordinator.py Outdated

heikkih requested a review from Copilot May 13, 2026 12:31

Copilot started reviewing on behalf of heikkih May 13, 2026 12:32 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

joostlek requested changes May 13, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/entity.py

Comment thread homeassistant/components/prusalink/sensor.py

home-assistant Bot marked this pull request as draft May 13, 2026 16:39

Copilot AI review requested due to automatic review settings May 15, 2026 10:29

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread tests/components/prusalink/conftest.py

heikkih force-pushed the chore/prusalink-bump-3.0.0 branch from fa62279 to 26f5a7e Compare May 16, 2026 14:01

Copilot AI review requested due to automatic review settings May 16, 2026 14:20

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/sensor.py Outdated

Comment thread homeassistant/components/prusalink/sensor.py Outdated

Comment thread tests/components/prusalink/conftest.py

Comment thread tests/components/prusalink/conftest.py

heikkih requested a review from Copilot May 16, 2026 14:55

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/sensor.py Outdated

Comment thread tests/components/prusalink/conftest.py

Comment thread tests/components/prusalink/conftest.py

heikkih added 3 commits May 21, 2026 11:38

prusalink: wrap job helper docstrings

afa3870

Remove unused job timestamp helpers in prusalink

3ea8d6a

prusalink: finalize minimal pyprusalink 3.0 bump adjustments

3902167

heikkih reopened this May 21, 2026

heikkih added 3 commits May 21, 2026 12:50

Merge branch 'home-assistant:dev' into chore/prusalink-bump-3.0.0

fc380cf

Move improved handling of legacyprinter to followup-PR

41a9d7c

prusalink: keep bump scope and fix binary_sensor mypy

71a1aad

Copilot AI review requested due to automatic review settings May 21, 2026 11:11

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread tests/components/prusalink/conftest.py

Comment thread homeassistant/components/prusalink/coordinator.py

Comment thread homeassistant/components/prusalink/coordinator.py

prusalink: fix mypy in config_flow and sensor

31ff0ed

heikkih marked this pull request as ready for review May 21, 2026 11:25

Copilot AI review requested due to automatic review settings May 21, 2026 11:25

home-assistant Bot requested a review from erwindouna May 21, 2026 11:25

Copilot AI reviewed May 21, 2026

View reviewed changes

erwindouna previously requested changes May 21, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/binary_sensor.py Outdated

Comment thread homeassistant/components/prusalink/config_flow.py Outdated

Comment thread homeassistant/components/prusalink/coordinator.py

home-assistant Bot marked this pull request as draft May 21, 2026 12:56

heikkih added 2 commits May 21, 2026 18:46

prusalink: rollback fixes for previous local typing-errors

d0b43a9

prusalink: align typing fixes with CI mypy checks

90bc2df

Copilot AI review requested due to automatic review settings May 21, 2026 17:24

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread tests/components/prusalink/conftest.py

Comment thread homeassistant/components/prusalink/binary_sensor.py Outdated

prusalink: narrow status_connect typing for mypy with 3.0.0

6848861

heikkih marked this pull request as ready for review May 21, 2026 17:46

Copilot AI review requested due to automatic review settings May 21, 2026 17:46

home-assistant Bot requested a review from erwindouna May 21, 2026 17:46

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread homeassistant/components/prusalink/config_flow.py

Comment thread tests/components/prusalink/conftest.py

joostlek approved these changes May 26, 2026

View reviewed changes

joostlek merged commit 81efe6d into home-assistant:dev May 26, 2026
48 checks passed

Uh oh!

Conversation

heikkih commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heikkih commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

erwindouna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

heikkih commented May 21, 2026

Uh oh!

Copilot AI left a comment

heikkih commented May 13, 2026 •

edited

Loading