Skip to content

Add repairs flow type hints#170359

Closed
iluvdata wants to merge 2 commits into
home-assistant:devfrom
iluvdata:pylint-hints
Closed

Add repairs flow type hints#170359
iluvdata wants to merge 2 commits into
home-assistant:devfrom
iluvdata:pylint-hints

Conversation

@iluvdata
Copy link
Copy Markdown
Contributor

Proposed change

Add pylint hints for RepairFlows returning RepairsFlowResults per #170263 (review)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to PR: Add RepairsFlowResult TypeAlias #170263
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Copilot AI review requested due to automatic review settings May 11, 2026 20:55
@iluvdata iluvdata requested a review from a team as a code owner May 11, 2026 20:55
@home-assistant home-assistant Bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels May 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Home Assistant’s custom pylint plugin to enforce that RepairsFlow step methods (async_step_*) declare the RepairsFlowResult return type, aligning repairs flows with the new RepairsFlowResult TypeAlias introduced in core.

Changes:

  • Add a ClassTypeHintMatch intended to require async_step_* methods on RepairsFlow subclasses to return RepairsFlowResult.

Comment thread pylint/plugins/hass_enforce_type_hints.py
Comment thread pylint/plugins/hass_enforce_type_hints.py
@home-assistant home-assistant Bot marked this pull request as draft May 12, 2026 05:43
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@iluvdata iluvdata marked this pull request as ready for review May 12, 2026 11:26
Copilot AI review requested due to automatic review settings May 12, 2026 11:26
@home-assistant home-assistant Bot requested a review from epenet May 12, 2026 11:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@iluvdata iluvdata closed this May 18, 2026
@iluvdata iluvdata deleted the pylint-hints branch May 18, 2026 20:17
@iluvdata
Copy link
Copy Markdown
Contributor Author

Unable to merge for reasons I don't understand. Will recreate.

@iluvdata iluvdata mentioned this pull request May 18, 2026
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants