Update Indevolt integration quality scale to platinum#170320
Merged
joostlek merged 2 commits intoMay 21, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to raise the Indevolt integration to platinum quality scale by adding DHCP-based discovery and tightening translated error handling, while updating the integration’s dependency and tests accordingly.
Changes:
- Add DHCP discovery config flow support (with confirmation step) and corresponding tests; update generated DHCP matchers.
- Replace string-based write failures with a translated
write_errorexception and update tests to exercise boolean write failures. - Bump
indevolt-apito 1.7.2 and mark the integration as platinum inmanifest.json/quality_scale.yaml.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/components/indevolt/test_switch.py | Updates write-failure test to reflect boolean set_data failure behavior. |
| tests/components/indevolt/test_services.py | Updates service execution-failure tests to reflect boolean set_data failure behavior. |
| tests/components/indevolt/test_select.py | Updates select write-failure test to reflect boolean set_data failure behavior. |
| tests/components/indevolt/test_number.py | Updates number write-failure test to reflect boolean set_data failure behavior. |
| tests/components/indevolt/test_config_flow.py | Adds DHCP discovery flow tests and aligns titles/models with shared constants. |
| tests/components/indevolt/conftest.py | Introduces shared host/model constants used across Indevolt tests. |
| requirements_test_all.txt | Bumps indevolt-api to 1.7.2 for tests. |
| requirements_all.txt | Bumps indevolt-api to 1.7.2 for runtime. |
| homeassistant/generated/dhcp.py | Adds Indevolt DHCP discovery match patterns (generated output). |
| homeassistant/components/indevolt/switch.py | Raises translated write_error on write failure. |
| homeassistant/components/indevolt/strings.json | Adds DHCP discovery confirmation strings and write_error exception translation. |
| homeassistant/components/indevolt/select.py | Raises translated write_error on write failure. |
| homeassistant/components/indevolt/quality_scale.yaml | Marks discovery and exception translation rules done; targets platinum. |
| homeassistant/components/indevolt/number.py | Raises translated write_error on write failure. |
| homeassistant/components/indevolt/manifest.json | Adds DHCP discovery, bumps dependency, sets quality scale to platinum. |
| homeassistant/components/indevolt/coordinator.py | Simplifies write/push path (but now lacks translated exception handling for write I/O errors). |
| homeassistant/components/indevolt/config_flow.py | Implements DHCP discovery + confirmation step and extends connection error handling. |
b25d69d to
a2a9a52
Compare
joostlek
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update the integration to platinum quality scale.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: