Skip to content

Update Indevolt integration quality scale to platinum#170320

Merged
joostlek merged 2 commits into
home-assistant:devfrom
Xirt:indevolt-platinum-quality-scale
May 21, 2026
Merged

Update Indevolt integration quality scale to platinum#170320
joostlek merged 2 commits into
home-assistant:devfrom
Xirt:indevolt-platinum-quality-scale

Conversation

@Xirt
Copy link
Copy Markdown
Contributor

@Xirt Xirt commented May 11, 2026

Proposed change

Update the integration to platinum quality scale.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to raise the Indevolt integration to platinum quality scale by adding DHCP-based discovery and tightening translated error handling, while updating the integration’s dependency and tests accordingly.

Changes:

  • Add DHCP discovery config flow support (with confirmation step) and corresponding tests; update generated DHCP matchers.
  • Replace string-based write failures with a translated write_error exception and update tests to exercise boolean write failures.
  • Bump indevolt-api to 1.7.2 and mark the integration as platinum in manifest.json / quality_scale.yaml.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/components/indevolt/test_switch.py Updates write-failure test to reflect boolean set_data failure behavior.
tests/components/indevolt/test_services.py Updates service execution-failure tests to reflect boolean set_data failure behavior.
tests/components/indevolt/test_select.py Updates select write-failure test to reflect boolean set_data failure behavior.
tests/components/indevolt/test_number.py Updates number write-failure test to reflect boolean set_data failure behavior.
tests/components/indevolt/test_config_flow.py Adds DHCP discovery flow tests and aligns titles/models with shared constants.
tests/components/indevolt/conftest.py Introduces shared host/model constants used across Indevolt tests.
requirements_test_all.txt Bumps indevolt-api to 1.7.2 for tests.
requirements_all.txt Bumps indevolt-api to 1.7.2 for runtime.
homeassistant/generated/dhcp.py Adds Indevolt DHCP discovery match patterns (generated output).
homeassistant/components/indevolt/switch.py Raises translated write_error on write failure.
homeassistant/components/indevolt/strings.json Adds DHCP discovery confirmation strings and write_error exception translation.
homeassistant/components/indevolt/select.py Raises translated write_error on write failure.
homeassistant/components/indevolt/quality_scale.yaml Marks discovery and exception translation rules done; targets platinum.
homeassistant/components/indevolt/number.py Raises translated write_error on write failure.
homeassistant/components/indevolt/manifest.json Adds DHCP discovery, bumps dependency, sets quality scale to platinum.
homeassistant/components/indevolt/coordinator.py Simplifies write/push path (but now lacks translated exception handling for write I/O errors).
homeassistant/components/indevolt/config_flow.py Implements DHCP discovery + confirmation step and extends connection error handling.

Comment thread homeassistant/components/indevolt/coordinator.py
@Xirt Xirt force-pushed the indevolt-platinum-quality-scale branch from b25d69d to a2a9a52 Compare May 20, 2026 20:38
Copilot AI review requested due to automatic review settings May 20, 2026 20:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@Xirt Xirt marked this pull request as ready for review May 20, 2026 20:40
@Xirt Xirt marked this pull request as draft May 20, 2026 20:44
@Xirt Xirt marked this pull request as ready for review May 21, 2026 04:56
Copilot AI review requested due to automatic review settings May 21, 2026 04:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/indevolt/manifest.json
@joostlek joostlek merged commit f290dcc into home-assistant:dev May 21, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants