Skip to content

Use VERSION from PrusaLinkConfigFlow in prusalink #170200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abmantis merged 2 commits into from
May 10, 2026
Merged

Use VERSION from PrusaLinkConfigFlow in prusalink #170200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8708b28
prusalink: read VERSION from PrusaLinkConfigFlow, not the HA base class
heikkih May 9, 2026
423fe43
prusalink: also guard migration against future minor versions
heikkih May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/prusalink/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from homeassistant.helpers import issue_registry as ir
from homeassistant.helpers.httpx_client import get_async_client

from .config_flow import ConfigFlow
from .config_flow import PrusaLinkConfigFlow
from .const import DOMAIN
from .coordinator import (
InfoUpdateCoordinator,
Expand Down Expand Up @@ -67,7 +67,10 @@ async def async_setup_entry(hass: HomeAssistant, entry: PrusaLinkConfigEntry) ->

async def async_migrate_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> bool:
"""Migrate old entry."""
if config_entry.version > ConfigFlow.VERSION:
if (config_entry.version, config_entry.minor_version) > (
PrusaLinkConfigFlow.VERSION,
PrusaLinkConfigFlow.MINOR_VERSION,
):
# This means the user has downgraded from a future version
return False

Expand Down
22 changes: 20 additions & 2 deletions tests/components/prusalink/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pytest

from homeassistant.components.prusalink import DOMAIN
from homeassistant.components.prusalink.config_flow import ConfigFlow
from homeassistant.components.prusalink.config_flow import PrusaLinkConfigFlow
from homeassistant.config_entries import ConfigEntry, ConfigEntryState
from homeassistant.const import CONF_API_KEY, CONF_HOST, CONF_PASSWORD, CONF_USERNAME
from homeassistant.core import HomeAssistant
Expand Down Expand Up @@ -174,7 +174,25 @@ async def test_migration_fails_on_future_version(
entry = MockConfigEntry(
domain=DOMAIN,
data={},
version=ConfigFlow.VERSION + 1,
version=PrusaLinkConfigFlow.VERSION + 1,
)
entry.add_to_hass(hass)

await hass.config_entries.async_setup(entry.entry_id)
await hass.async_block_till_done()

assert entry.state is ConfigEntryState.MIGRATION_ERROR


async def test_migration_fails_on_future_minor_version(
hass: HomeAssistant, issue_registry: ir.IssueRegistry
) -> None:
"""Test migrating fails on the current version with a higher minor version."""
entry = MockConfigEntry(
domain=DOMAIN,
data={},
version=PrusaLinkConfigFlow.VERSION,
minor_version=PrusaLinkConfigFlow.MINOR_VERSION + 1,
)
entry.add_to_hass(hass)

Expand Down
Loading