End nobo_hub config flow tests in CREATE_ENTRY or ABORT

[oyvindwe]

Proposed change

End nobo_hub config flow tests in CREATE_ENTRY or ABORT

Discovered during review of PR #168638

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to developer documentation pull request:
• Link to frontend pull request:

Checklist

• I understand the code I am submitting and can explain how it works.
• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.
• Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration (nobo_hub) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nobo_hub can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant mark-draft Mark the pull request as draft.
• @home-assistant ready-for-review Remove the draft status from the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign nobo_hub Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant update-branch Update the pull request branch with the base branch.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

[Copilot]

Pull request overview

This PR updates the nobo_hub config flow test suite to ensure flows always end in a terminal state (CREATE_ENTRY or ABORT), avoiding tests that leave flows mid-progress.

Changes:

• Extend several config flow tests that previously ended on an error form to retry with valid input and finish with CREATE_ENTRY.
• Split previously parameterized DHCP discovery scenarios into separate tests that each end in ABORT or proceed to a completed CREATE_ENTRY.

Comments suppressed due to low confidence (2)

tests/components/nobo_hub/test_config_flow.py:235

• Remove the unused async_discover_hubs patch (or start the flow from the user step) since starting the flow with source="manual" calls async_step_manual directly and never performs hub discovery.

    with patch(
        "homeassistant.components.nobo_hub.config_flow.nobo.async_discover_hubs",
        return_value=[],
    ):
        result = await hass.config_entries.flow.async_init(

tests/components/nobo_hub/test_config_flow.py:277

• Remove the unused async_discover_hubs patch (or start the flow from the user step) since initializing the flow with source="manual" goes straight to async_step_manual and does not run discovery.

    with patch(
        "homeassistant.components.nobo_hub.config_flow.nobo.async_discover_hubs",
        return_value=[("1.1.1.1", "123456789")],
    ):
        result = await hass.config_entries.flow.async_init(

[joostlek]

There's a merge conflict, can you take a look?

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.