Skip to content

Drop nobo_hub custom select device class #170135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oyvindwe wants to merge 5 commits into
base: dev
Choose a base branch
from
+2 −8
Open

Drop nobo_hub custom select device class #170135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
153e090
Drop nobo_hub custom select device class
oyvindwe May 8, 2026
7fe4601
Merge branch 'dev' into nobo_hub-drop-custom-device-class
oyvindwe May 14, 2026
1e811d8
Mark entity-device-class as done
oyvindwe May 14, 2026
075b3bf
Merge branch 'dev' into nobo_hub-drop-custom-device-class
oyvindwe May 14, 2026
0c117dc
Merge branch 'dev' into nobo_hub-drop-custom-device-class
oyvindwe May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions homeassistant/components/nobo_hub/quality_scale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,7 @@ rules:
docs-use-cases: todo
dynamic-devices: todo
entity-category: todo
entity-device-class:
status: todo
comment: >
Custom device class on global override select being dropped in
PR #170135.
entity-device-class: done
entity-disabled-by-default: todo
entity-translations: todo
exception-translations: done
Expand Down
1 change: 0 additions & 1 deletion homeassistant/components/nobo_hub/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ class NoboGlobalSelector(NoboBaseEntity, SelectEntity):
"""Global override selector for Nobø Ecohub."""

_attr_translation_key = "global_override"
_attr_device_class = "nobo_hub__override"
_modes = {
nobo.API.OVERRIDE_MODE_NORMAL: "none",
nobo.API.OVERRIDE_MODE_AWAY: "away",
Expand Down
3 changes: 1 addition & 2 deletions tests/components/nobo_hub/snapshots/test_select.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
'object_id_base': 'Global override',
'options': dict({
}),
'original_device_class': 'nobo_hub__override',
'original_device_class': None,
'original_icon': None,
'original_name': 'Global override',
'platform': 'nobo_hub',
Expand All @@ -103,7 +103,6 @@
# name: test_select_entities[select.my_eco_hub_global_override-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'nobo_hub__override',
'friendly_name': 'My Eco Hub Global override',
'options': list([
'none',
Expand Down