Skip to content

data grand lyon: update quality scale in manifest#170109

Merged
erwindouna merged 1 commit into
home-assistant:devfrom
Crocmagnon:patch-2
May 8, 2026
Merged

data grand lyon: update quality scale in manifest#170109
erwindouna merged 1 commit into
home-assistant:devfrom
Crocmagnon:patch-2

Conversation

@Crocmagnon
Copy link
Copy Markdown
Contributor

@Crocmagnon Crocmagnon commented May 8, 2026

Proposed change

Update quality scale following #170059, sorry for the noise I missed it in the previous PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Data Grand Lyon integration’s declared Integration Quality Scale tier in manifest.json to reflect the current status tracked in its quality_scale.yaml.

Changes:

  • Bump quality_scale in the integration manifest from bronze to silver.

@Crocmagnon Crocmagnon marked this pull request as ready for review May 8, 2026 12:07
@erwindouna
Copy link
Copy Markdown
Member

Can you link to the PR that went through the Silver qualification? That way there's justification we can accept the integration went from bronze to silver.

@silamon
Copy link
Copy Markdown
Contributor

silamon commented May 8, 2026

Can you link to the PR that went through the Silver qualification? That way there's justification we can accept the integration went from bronze to silver.

It's linked in the proposed changes.

@Crocmagnon
Copy link
Copy Markdown
Contributor Author

Crocmagnon commented May 8, 2026

@erwindouna it’s #170059, linked in the PR description 🙂 ; let me know if that doesn’t answer your question.

@erwindouna
Copy link
Copy Markdown
Member

@erwindouna it’s #170059, linked in the PR description 🙂

That one is focusing on the reauth. Is there a PR where you showed work on the Silver integration and updated the quality_scale.yaml?

@Crocmagnon
Copy link
Copy Markdown
Contributor Author

The first PR of this integration initially covered everything up to silver, but I was asked to keep reauth for a subsequent PR.
#167946
The present PR is the third for this integration.

@erwindouna
Copy link
Copy Markdown
Member

The first PR of this integration initially covered everything up to silver, but I was asked to keep reauth for a subsequent PR. #167946 The present PR is the third for this integration.

Thanks for sharing the details - I need some prove to back it up. :)

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Crocmagnon!

@erwindouna erwindouna merged commit af6fcae into home-assistant:dev May 8, 2026
36 of 37 checks passed
@Crocmagnon
Copy link
Copy Markdown
Contributor Author

Sure! No problem 🙂 thank you for reviewing and merging!

@Crocmagnon Crocmagnon deleted the patch-2 branch May 8, 2026 21:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants