Add has_entity_name and translation keys to blebox entities#170089
Open
bkobus-bbx wants to merge 6 commits into
Open
Add has_entity_name and translation keys to blebox entities#170089bkobus-bbx wants to merge 6 commits into
bkobus-bbx wants to merge 6 commits into
Conversation
Contributor
|
Hey there @bbx-a, @swistakm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the BleBox integration to Home Assistant’s has_entity_name + translation_key naming pattern, updating entity implementations and corresponding tests so entity names are derived from device names and translated entity labels (with optional indexing for multi-instance features).
Changes:
- Set a shared
has_entity_namebehavior in the BleBox base entity and update platforms to usetranslation_key/ translated names (or device-name-only where appropriate). - Add entity translation keys (and config-flow field descriptions) to
strings.json. - Update and extend BleBox tests to validate new entity IDs and naming behavior (including multi-instance suffixes and feature-provided names).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/blebox/entity.py | Enables has_entity_name for all BleBox entities and adjusts update-error logging. |
| homeassistant/components/blebox/strings.json | Adds config-flow data_description plus entity translation_key name mappings with {index} placeholders. |
| homeassistant/components/blebox/sensor.py | Adds translation_key to sensor descriptions and applies optional per-device-class indexing via translation placeholders. |
| homeassistant/components/blebox/light.py | Uses a translated “channel” name for indexed light features and updates error messages to reference feature identifiers. |
| homeassistant/components/blebox/switch.py | Implements naming rules for relays: feature name wins, otherwise translated “relay” with optional index or device-name-only. |
| homeassistant/components/blebox/binary_sensor.py | Adds translation keys and naming rules: feature name wins, otherwise translated name with optional index. |
| homeassistant/components/blebox/cover.py | Sets cover entities to device-name-only naming under has_entity_name. |
| homeassistant/components/blebox/climate.py | Sets climate entities to device-name-only naming under has_entity_name. |
| homeassistant/components/blebox/button.py | Sets button entities to device-name-only naming under has_entity_name. |
| tests/components/blebox/test_sensor.py | Updates expected entity IDs/names and adds coverage for multi-sensor indexing behavior. |
| tests/components/blebox/test_light.py | Updates expected entity IDs/names and adds coverage for multi-channel light naming. |
| tests/components/blebox/test_switch.py | Updates expected entity IDs/names and adds coverage for feature-provided switch names. |
| tests/components/blebox/test_binary_sensor.py | Updates expected entity IDs/names and adds coverage for indexed and feature-named binary sensors. |
| tests/components/blebox/test_cover.py | Updates expected cover entity IDs and names for device-name-only naming. |
| tests/components/blebox/test_climate.py | Updates expected climate entity IDs and names for device-name-only naming. |
| tests/components/blebox/test_button.py | Updates expected button entity IDs and names for device-name-only naming. |
21 tasks
bkobus-bbx
force-pushed
the
blebox/entity-naming
branch
from
fe5a3b4 to
4bc69e3
Compare
joostlek
requested changes
May 13, 2026
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bkobus-bbx
force-pushed
the
blebox/entity-naming
branch
from
e349508 to
b5da46a
Compare
Contributor
Author
|
Is there anything more to fix/explain? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Migrates the blebox integration to the has_entity_name pattern. All entity types now use translation_key with {index} placeholders in strings.json for proper naming. Multi-instance entities (e.g. multiple relays, channels, or sensors of the same device class) get a numbered suffix. Single-instance entities expose only the device name.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: