Skip to content

Fix is_closed state for DynamicGarageDoor in Overkiz #170052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zweckj merged 7 commits into from
May 8, 2026
+451 −1
Merged

Fix is_closed state for DynamicGarageDoor in Overkiz #170052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffc9c3c
Fix DynamicGarageDoor unknown state in Overkiz cover
iMicknl May 7, 2026
c5529ca
Fix Overkiz cover descriptions for GarageDoor UIClass and update posi…
iMicknl May 7, 2026
c8eb37c
Add OGP DynamicGarageDoor variant to test suite and clean up
iMicknl May 7, 2026
0919ba0
Fix snapshot bloat: keep one entry per fixture file in SNAPSHOT_FIXTURES
iMicknl May 7, 2026
ed71c4b
Add PositionableGarageDoorWithPartialPosition widget override
iMicknl May 7, 2026
0c6738e
Clarify comments for PositionableGarageDoor and PositionableGarageDoo…
iMicknl May 7, 2026
b2ca823
Add position control
iMicknl May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion homeassistant/components/overkiz/cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,32 @@ class OverkizCoverDescription(CoverEntityDescription):
close_tilt_command_args=(15, 1), # position (1-127), speed (1-15)
stop_tilt_command=OverkizCommand.STOP,
),
# Needs override since PositionableGarageDoor reports
# core:OpenClosedUnknownState instead of core:OpenClosedState
# uiClass is GarageDoor
OverkizCoverDescription(
key=UIWidget.POSITIONABLE_GARAGE_DOOR,
device_class=CoverDeviceClass.GARAGE,
current_position_state=OverkizState.CORE_CLOSURE,
set_position_command=OverkizCommand.SET_CLOSURE,
open_command=OverkizCommand.OPEN,
close_command=OverkizCommand.CLOSE,
stop_command=OverkizCommand.STOP,
is_closed_state=OverkizState.CORE_OPEN_CLOSED_UNKNOWN,
Comment thread
iMicknl marked this conversation as resolved.
),
Comment on lines +127 to +139
Copy link
Copy Markdown
Member Author

@iMicknl iMicknl May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in a follow-up PR, good catch. Not related to this change and previous behavior.

# Needs override since PositionableGarageDoorWithPartialPosition reports
# core:OpenClosedPartialState instead of core:OpenClosedState
# uiClass is GarageDoor
OverkizCoverDescription(
key=UIWidget.POSITIONABLE_GARAGE_DOOR_WITH_PARTIAL_POSITION,
device_class=CoverDeviceClass.GARAGE,
current_position_state=OverkizState.CORE_CLOSURE,
set_position_command=OverkizCommand.SET_CLOSURE,
open_command=OverkizCommand.OPEN,
close_command=OverkizCommand.CLOSE,
stop_command=OverkizCommand.STOP,
is_closed_state=OverkizState.CORE_OPEN_CLOSED_PARTIAL,
),
# Needs override to support this Generic device (rts:GenericRTSComponent)
# uiClass is Generic (not mapped to cover as this is a Generic device class)
OverkizCoverDescription(
Expand Down Expand Up @@ -200,7 +226,7 @@ class OverkizCoverDescription(CoverEntityDescription):
set_position_command=OverkizCommand.SET_CLOSURE,
open_command=OverkizCommand.OPEN,
close_command=OverkizCommand.CLOSE,
is_closed_state=OverkizState.CORE_OPEN_CLOSED_UNKNOWN,
is_closed_state=OverkizState.CORE_OPEN_CLOSED,
stop_command=OverkizCommand.STOP,
),
OverkizCoverDescription(
Expand Down
232 changes: 232 additions & 0 deletions tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7370,6 +7370,238 @@
"widget": "DiscreteGateWithPedestrianPosition",
"oid": "6ba9b1de-8037-41d7-9150-21f7d5f49a3f",
"uiClass": "Gate"
},
{
"creationTime": 1521964729000,
"lastUpdateTime": 1521964729000,
"label": "Garage Door",
"deviceURL": "io://1234-1234-6233/16730050",
"shortcut": false,
"controllableName": "io:DynamicGarageDoorComponent",
"definition": {
"commands": [
{
"commandName": "close",
"nparams": 0
},
{
"commandName": "getName",
"nparams": 0
},
{
"commandName": "identify",
"nparams": 0
},
{
"commandName": "open",
"nparams": 0
},
{
"commandName": "stop",
"nparams": 0
}
],
"states": [
{
"type": "DiscreteState",
"values": ["closed", "open"],
"qualifiedName": "core:OpenClosedState"
},
{
"type": "DiscreteState",
"values": ["available", "unavailable"],
"qualifiedName": "core:StatusState"
}
],
"widgetName": "DynamicGarageDoor",
"uiProfiles": ["OpenClose"],
"uiClass": "GarageDoor",
"qualifiedName": "io:DynamicGarageDoorComponent",
"type": "ACTUATOR"
},
"states": [
{
"name": "core:OpenClosedState",
"type": 3,
"value": "closed"
},
{
"name": "core:StatusState",
"type": 3,
"value": "available"
}
],
"attributes": [
{
"name": "core:Manufacturer",
"type": 3,
"value": "Somfy"
}
],
"available": true,
"enabled": true,
"placeOID": "bcbb34ef-2241-43a1-9c5b-523aa0563ec3",
"widget": "DynamicGarageDoor",
"type": 1,
"oid": "a5d47351-52d0-4a4c-a52d-abcdef123456",
"uiClass": "GarageDoor"
},
{
"creationTime": 1521964729000,
"lastUpdateTime": 1521964729000,
"label": "OGP Garage Door",
"deviceURL": "ogp://1234-1234-6233/6632544",
"shortcut": false,
"controllableName": "ogp:GarageDoor",
"definition": {
"commands": [
{
"commandName": "close",
"nparams": 0
},
{
"commandName": "identify",
"nparams": 0
},
{
"commandName": "open",
"nparams": 0
},
{
"commandName": "stop",
"nparams": 0
}
],
"states": [
{
"type": "DiscreteState",
"values": ["available", "unavailable"],
"qualifiedName": "core:AvailabilityState"
},
{
"type": "DiscreteState",
"values": ["closed", "open"],
"qualifiedName": "core:OpenClosedState"
},
{
"type": "DiscreteState",
"values": ["available", "unavailable"],
"qualifiedName": "core:StatusState"
}
],
"widgetName": "DynamicGarageDoor",
"uiProfiles": ["StatefulOpenClose", "OpenClose"],
"uiClass": "GarageDoor",
"qualifiedName": "ogp:GarageDoor",
"type": "ACTUATOR"
},
"states": [
{
"name": "core:AvailabilityState",
"type": 3,
"value": "available"
},
{
"name": "core:StatusState",
"type": 3,
"value": "available"
},
{
"name": "core:OpenClosedState",
"type": 3,
"value": "closed"
}
],
"attributes": [
{
"name": "core:Manufacturer",
"type": 3,
"value": "Somfy"
},
{
"name": "core:Technology",
"type": 3,
"value": "io2way"
}
],
"available": true,
"enabled": true,
"placeOID": "bcbb34ef-2241-43a1-9c5b-523aa0563ec3",
"widget": "DynamicGarageDoor",
"type": 1,
"oid": "2492f7ae-3711-4160-9dae-e8910b708ce1",
"uiClass": "GarageDoor"
},
{
"creationTime": 1521964729000,
"lastUpdateTime": 1521964729000,
"label": "Partial Garage Door",
"deviceURL": "io://1234-1234-6233/7433515",
"shortcut": false,
"controllableName": "io:DiscreteGarageOpenerWithPartialPositionIOComponent",
"definition": {
"commands": [
{
"commandName": "close",
"nparams": 0
},
{
"commandName": "open",
"nparams": 0
},
{
"commandName": "partialPosition",
"nparams": 0
},
{
"commandName": "stop",
"nparams": 0
}
],
"states": [
{
"type": "DiscreteState",
"values": ["closed", "open", "partial"],
"qualifiedName": "core:OpenClosedPartialState"
},
{
"type": "DiscreteState",
"values": ["available", "unavailable"],
"qualifiedName": "core:StatusState"
}
],
"widgetName": "PositionableGarageDoorWithPartialPosition",
"uiProfiles": ["OpenClose"],
"uiClass": "GarageDoor",
"qualifiedName": "io:DiscreteGarageOpenerWithPartialPositionIOComponent",
"type": "ACTUATOR"
},
"states": [
{
"name": "core:StatusState",
"type": 3,
"value": "available"
},
{
"name": "core:OpenClosedPartialState",
"type": 3,
"value": "closed"
}
],
"attributes": [
{
"name": "core:Manufacturer",
"type": 3,
"value": "Somfy"
}
],
"available": true,
"enabled": true,
"placeOID": "bcbb34ef-2241-43a1-9c5b-523aa0563ec3",
"widget": "PositionableGarageDoorWithPartialPosition",
"type": 1,
"oid": "f1a2b3c4-d5e6-7890-abcd-ef1234567890",
"uiClass": "GarageDoor"
}
],
"zones": [],
Expand Down
Loading