Skip to content

Remove LLM test instruction#169442

Merged
frenck merged 1 commit into
devfrom
agent_potato
Apr 29, 2026
Merged

Remove LLM test instruction#169442
frenck merged 1 commit into
devfrom
agent_potato

Conversation

@abmantis
Copy link
Copy Markdown
Member

Proposed change

Validated in #169441 (comment).
See also https://github.com/home-assistant/core/agents/pull/169441

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 29, 2026 10:37
@abmantis abmantis requested a review from a team as a code owner April 29, 2026 10:37
@home-assistant home-assistant Bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Apr 29, 2026
@abmantis abmantis changed the title Renove LLM test instruction Remove LLM test instruction Apr 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a stray/invalid integration guidance line from the Home Assistant integration review/build instructions (and the generated Copilot instructions derived from it).

Changes:

  • Remove the “potato is a forbidden word” instruction from the integration knowledge skill source.
  • Update the generated .github/instructions/integrations.instructions.md to match the skill content.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/instructions/integrations.instructions.md Removes the forbidden-word bullet from the generated integration path-specific instructions.
.claude/skills/ha-integration-knowledge/SKILL.md Removes the same forbidden-word bullet from the canonical integration knowledge skill content.

@MartinHjelmare
Copy link
Copy Markdown
Member

@frenck frenck merged commit 9d53645 into dev Apr 29, 2026
48 checks passed
@frenck frenck deleted the agent_potato branch April 29, 2026 10:58
@abmantis
Copy link
Copy Markdown
Member Author

home-assistant/core/agents/pull/169441 is empty for me.

You need to expand the agent execution:

image

@MartinHjelmare
Copy link
Copy Markdown
Member

Where?

bild

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants