Rename timer last_action to last_transition#169430
Merged
Merged
Conversation
emontnemery
commented
Apr 29, 2026
| "name": "Finishes at" | ||
| }, | ||
| "last_transition": { | ||
| "name": "Last transition", |
Contributor
Author
There was a problem hiding this comment.
I'm not sure this is understandable?
Member
There was a problem hiding this comment.
I think it's good. It's better than last action as we didn't include all actions in last action.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the Timer entity state attribute last_action to last_transition in the timer integration, updating the integration code, tests, and UI strings accordingly.
Changes:
- Renamed the timer attribute constant and internal field from
last_actiontolast_transition. - Updated timer tests to assert on
last_transitioninstead oflast_action. - Added translation strings for the new
last_transitionstate attribute (including value labels like started/paused/etc).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
homeassistant/components/timer/__init__.py |
Renames the exposed state attribute and the internal tracking field to last_transition, and updates restore logic accordingly. |
homeassistant/components/timer/strings.json |
Adds translated name + value labels for the new last_transition attribute. |
tests/components/timer/test_init.py |
Updates all assertions and a couple of test names/docstrings to use last_transition. |
MartinHjelmare
approved these changes
Apr 29, 2026
Contributor
Author
|
The bot comments about this being a breaking change are technically correct, but the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Rename timer
last_actiontolast_transitionType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: