Reject manifest dependencies on core integrations in hassfest

homeassistant/components/recovery_mode/manifest.json

@@ -3,7 +3,6 @@
   "name": "Recovery Mode",
   "codeowners": ["@home-assistant/core"],
   "config_flow": false,
-  "dependencies": ["persistent_notification"],
   "documentation": "https://www.home-assistant.io/integrations/recovery_mode",
   "integration_type": "system",
   "quality_scale": "internal"

script/hassfest/dependencies.py

@@ -7,6 +7,7 @@
 import multiprocessing
 from pathlib import Path
 
+from homeassistant.bootstrap import CORE_INTEGRATIONS
 from homeassistant.const import Platform
 from homeassistant.requirements import DISCOVERY_INTEGRATIONS
 
@@ -332,6 +333,13 @@ def _validate_dependencies(
                     "dependencies", f"Dependency {dep} does not exist"
                 )
 
+            if dep in CORE_INTEGRATIONS:
+                integration.add_error(
+                    "dependencies",
+                    f"Dependency {dep} is a core integration and is "
+                    "unconditionally loaded",
+                )
+
 
 def validate(
     integrations: dict[str, Integration],

tests/hassfest/test_dependencies.py

@@ -4,7 +4,10 @@
 
 import pytest
 
-from script.hassfest.dependencies import ImportCollector
+from script.hassfest.dependencies import ImportCollector, _validate_dependencies
+from script.hassfest.model import Config
+
+from . import get_integration
 
 
 @pytest.fixture
@@ -90,3 +93,37 @@ def test_all_imports(mock_collector) -> None:
         "child_import_field",
         "renamed_absolute",
     }
+
+
+def test_dependency_on_core_integration_rejected(config: Config) -> None:
+    """Test that depending on a core integration is rejected."""
+    consumer = get_integration("consumer", config)
+    consumer.manifest["dependencies"] = ["persistent_notification"]
+
+    integrations = {
+        "consumer": consumer,
+        "persistent_notification": get_integration("persistent_notification", config),
+    }
+
+    _validate_dependencies(integrations)
+
+    assert len(consumer.errors) == 1
+    assert (
+        "Dependency persistent_notification is a core integration"
+        in consumer.errors[0].error
+    )
+
+
+def test_dependency_on_non_core_integration_allowed(config: Config) -> None:
+    """Test that depending on a non-core integration is not rejected."""
+    consumer = get_integration("consumer", config)
+    consumer.manifest["dependencies"] = ["other"]
+
+    integrations = {
+        "consumer": consumer,
+        "other": get_integration("other", config),
+    }
+
+    _validate_dependencies(integrations)
+
+    assert consumer.errors == []