Ensure homeassistant component is loaded before conversation#169386
Ensure homeassistant component is loaded before conversation#169386epenet wants to merge 1 commit into
Conversation
|
Hey there @home-assistant/core, @synesthesiam, @arturpragacz, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR ensures the homeassistant core integration is fully set up before conversation is set up, preventing startup-time failures when conversation relies on data initialized by homeassistant (e.g., exposed entities).
Changes:
- Add
homeassistantas an explicit dependency of theconversationintegration to enforce setup ordering.
arturpragacz
left a comment
There was a problem hiding this comment.
I'm not sure we want this, as this is only relevant for tests, we guarantee homeassistant component is set up first during bootstrap.
Indeed: core/homeassistant/bootstrap.py Line 147 in f3acae6 I think we should add checks to hassfest to ensure that CORE_INTEGRATIONS (and possibly others?) are prevented from being in manifest.json |
Proposed change
Alternative to #169385
Spotted in https://github.com/home-assistant/core/actions/runs/25057100718/job/73402201810?pr=162263
Needed for #162263
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: