Skip to content

Ensure homeassistant component is loaded before conversation#169386

Closed
epenet wants to merge 1 commit into
devfrom
epenet/20260428-1745
Closed

Ensure homeassistant component is loaded before conversation#169386
epenet wants to merge 1 commit into
devfrom
epenet/20260428-1745

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 28, 2026

Proposed change

Alternative to #169385

Spotted in https://github.com/home-assistant/core/actions/runs/25057100718/job/73402201810?pr=162263

Needed for #162263

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, @synesthesiam, @arturpragacz, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures the homeassistant core integration is fully set up before conversation is set up, preventing startup-time failures when conversation relies on data initialized by homeassistant (e.g., exposed entities).

Changes:

  • Add homeassistant as an explicit dependency of the conversation integration to enforce setup ordering.

Copy link
Copy Markdown
Member

@arturpragacz arturpragacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want this, as this is only relevant for tests, we guarantee homeassistant component is set up first during bootstrap.

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Apr 28, 2026

I'm not sure we want this, as this is only relevant for tests, we guarantee homeassistant component is set up first during bootstrap.

Indeed:

CORE_INTEGRATIONS = {"homeassistant", "persistent_notification"}

I think we should add checks to hassfest to ensure that CORE_INTEGRATIONS (and possibly others?) are prevented from being in manifest.json

@epenet epenet closed this Apr 29, 2026
@epenet epenet deleted the epenet/20260428-1745 branch April 29, 2026 06:46
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants