Use modern condition API in condition tests#169354
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates condition-related tests to use the modern ConditionChecker API by invoking async_check() directly instead of calling the checker as a legacy callable with hass.
Changes:
- Replace
cond(hass)/test(hass)style calls withcond.async_check()across multiple condition test modules. - Update shared condition test helpers to evaluate conditions via
async_check().
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/zone/test_condition.py | Switch zone condition evaluations to ConditionChecker.async_check() in error and behavior assertions. |
| tests/components/window/test_condition.py | Use async_check() for window condition evaluation in device class exclusion assertions. |
| tests/components/text/test_condition.py | Use async_check() when evaluating cross-domain text conditions. |
| tests/components/switch/test_condition.py | Use async_check() for cross-domain switch condition evaluation. |
| tests/components/select/test_condition.py | Use async_check() for cross-domain select/input_select condition evaluation. |
| tests/components/occupancy/test_condition.py | Use async_check() for occupancy device class exclusion assertions. |
| tests/components/motion/test_condition.py | Use async_check() for motion device class exclusion assertions. |
| tests/components/gate/test_condition.py | Use async_check() for gate device class exclusion assertions. |
| tests/components/garage_door/test_condition.py | Use async_check() for garage door device class exclusion assertions. |
| tests/components/door/test_condition.py | Use async_check() for door device class exclusion assertions. |
| tests/components/cover/test_condition.py | Use async_check() for cover device class exclusion assertions. |
| tests/components/common.py | Update shared helpers to assert condition behavior via cond.async_check(). |
MartinHjelmare
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use modern condition API in condition tests
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: