Skip to content

Use modern condition API in condition tests#169354

Merged
MartinHjelmare merged 1 commit into
devfrom
condition_tests_modern_api
Apr 28, 2026
Merged

Use modern condition API in condition tests#169354
MartinHjelmare merged 1 commit into
devfrom
condition_tests_modern_api

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Use modern condition API in condition tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 28, 2026 09:35
@emontnemery emontnemery requested a review from a team as a code owner April 28, 2026 09:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates condition-related tests to use the modern ConditionChecker API by invoking async_check() directly instead of calling the checker as a legacy callable with hass.

Changes:

  • Replace cond(hass) / test(hass) style calls with cond.async_check() across multiple condition test modules.
  • Update shared condition test helpers to evaluate conditions via async_check().

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/components/zone/test_condition.py Switch zone condition evaluations to ConditionChecker.async_check() in error and behavior assertions.
tests/components/window/test_condition.py Use async_check() for window condition evaluation in device class exclusion assertions.
tests/components/text/test_condition.py Use async_check() when evaluating cross-domain text conditions.
tests/components/switch/test_condition.py Use async_check() for cross-domain switch condition evaluation.
tests/components/select/test_condition.py Use async_check() for cross-domain select/input_select condition evaluation.
tests/components/occupancy/test_condition.py Use async_check() for occupancy device class exclusion assertions.
tests/components/motion/test_condition.py Use async_check() for motion device class exclusion assertions.
tests/components/gate/test_condition.py Use async_check() for gate device class exclusion assertions.
tests/components/garage_door/test_condition.py Use async_check() for garage door device class exclusion assertions.
tests/components/door/test_condition.py Use async_check() for door device class exclusion assertions.
tests/components/cover/test_condition.py Use async_check() for cover device class exclusion assertions.
tests/components/common.py Update shared helpers to assert condition behavior via cond.async_check().

@MartinHjelmare MartinHjelmare merged commit eb2217c into dev Apr 28, 2026
47 checks passed
@MartinHjelmare MartinHjelmare deleted the condition_tests_modern_api branch April 28, 2026 10:04
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants