Skip to content

Register a stub transport for ESPHome serial proxies via USB#169308

Merged
balloob merged 6 commits into
home-assistant:devfrom
puddly:puddly/usb-esphome-proxy-stub
Apr 27, 2026
Merged

Register a stub transport for ESPHome serial proxies via USB#169308
balloob merged 6 commits into
home-assistant:devfrom
puddly:puddly/usb-esphome-proxy-stub

Conversation

@puddly
Copy link
Copy Markdown
Contributor

@puddly puddly commented Apr 27, 2026

Proposed change

Integrations that depend on usb but not esphome can load earlier than the ESPHome integration, before the esphome-hass:// URI handler is registered with serialx. This causes them to fail with serialx.common.UnknownUriScheme.

This PR registers a second handler for esphome-hass:// with a lower weight. Integrations that try to connect before ESPHome has loaded will immediately fail with ConfigEntryNotReady. Once ESPHome loads, the real implementation of this serial transport will take over.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 27, 2026 16:17
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: esphome integration: usb Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 27, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (usb) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of usb can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign usb Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures esphome-hass:// serialx URLs fail gracefully (with ConfigEntryNotReady) when ESPHome hasn’t loaded yet, by registering a low-priority stub transport from the USB integration.

Changes:

  • Add a USB-owned stub esphome-hass:// serialx URI handler that raises ConfigEntryNotReady on open.
  • Adjust ESPHome’s register_uri_handler registration to use a distinct unique_scheme so multiple handlers can coexist.
  • Add a USB integration test that validates the stub handler is selected and raises the expected exception.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/usb/serial_proxy_stub.py New stub serialx URI handler/transport that raises ConfigEntryNotReady until ESPHome loads.
homeassistant/components/usb/__init__.py Imports the stub module to register the URI handler during USB integration import.
homeassistant/components/esphome/serial_proxy.py Updates handler registration to use a different unique_scheme to allow parallel registrations.
tests/components/usb/test_init.py Adds a test ensuring the stub handler is registered and raises ConfigEntryNotReady when opened.

Comment thread homeassistant/components/usb/serial_proxy_stub.py Outdated
Comment thread homeassistant/components/usb/__init__.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 27, 2026

we have bluetooth_adapters integration for similar load order problems to make sure components needed for bluetooth load before. Not sure if thats better or worse for this case

@puddly
Copy link
Copy Markdown
Contributor Author

puddly commented Apr 27, 2026

It's a bit of a weird situation here because integrations that rely on USB now have an implicit runtime dependency on ESPHome but only if an ESPHome serial proxy is actually used. These integrations typically only have "dependencies": ["usb"]. They'd need to be updated to also have "after_dependencies": ["esphome"], which is unreasonable IMO.

I see a few options:

  1. Have some way for integrations to specify forward dependencies (i.e. don't consider usb loaded until esphome also loads), as a way to do this automatically.
  2. The slightly messy, double runtime registration dance we do here.
  3. Have the USB integration break isolation and register the ESPHome serial proxy itself.

Copilot AI review requested due to automatic review settings April 27, 2026 18:31
@puddly puddly force-pushed the puddly/usb-esphome-proxy-stub branch from 0a5c18a to 69f1889 Compare April 27, 2026 18:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread tests/components/usb/test_init.py
Comment thread homeassistant/components/usb/serial_proxy_stub.py
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, its not as architecturally pure as I'd like, but the other options aren't particularly better so its pragmatic.

@balloob balloob merged commit 8ce1487 into home-assistant:dev Apr 27, 2026
89 of 90 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed has-tests integration: esphome integration: usb Quality Scale: internal Quality Scale: platinum Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants