Fix more Shelly tests for Python 3.14.3#169304
Merged
Merged
Conversation
Contributor
|
Hey there @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
commented
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Shelly integration tests to be robust under Python 3.14.3 by ensuring config entry setup completes (including background tasks) while simulating connection failures during device initialization.
Changes:
- Wrap selected config entry setups in a temporary
initialize()failure to exercise “sleeping device” late-setup paths. - Switch several
hass.async_block_till_done()calls towait_background_tasks=Trueto avoid leftover background tasks during/after test execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/components/shelly/test_coordinator.py |
Updates a sleeping-device coordinator test to patch initialization failure and wait for background tasks during setup. |
tests/components/shelly/test_config_flow.py |
Updates multiple sleeping-device config flow tests to patch initialization failure and wait for background tasks during setup. |
chemelli74
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Linked to https://github.com/home-assistant/core/actions/runs/24982630534/job/73149424430?pr=162263
Follow-up to #169301
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: