Skip to content

Fix more Shelly tests for Python 3.14.3#169304

Merged
frenck merged 5 commits into
devfrom
epenet/20260427-1745
Apr 27, 2026
Merged

Fix more Shelly tests for Python 3.14.3#169304
frenck merged 5 commits into
devfrom
epenet/20260427-1745

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 27, 2026

Proposed change

Linked to https://github.com/home-assistant/core/actions/runs/24982630534/job/73149424430?pr=162263

Follow-up to #169301

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 27, 2026 15:46
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: shelly small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 27, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Comment thread tests/components/shelly/test_config_flow.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Shelly integration tests to be robust under Python 3.14.3 by ensuring config entry setup completes (including background tasks) while simulating connection failures during device initialization.

Changes:

  • Wrap selected config entry setups in a temporary initialize() failure to exercise “sleeping device” late-setup paths.
  • Switch several hass.async_block_till_done() calls to wait_background_tasks=True to avoid leftover background tasks during/after test execution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
tests/components/shelly/test_coordinator.py Updates a sleeping-device coordinator test to patch initialization failure and wait for background tasks during setup.
tests/components/shelly/test_config_flow.py Updates multiple sleeping-device config flow tests to patch initialization failure and wait for background tasks during setup.

Comment thread tests/components/shelly/test_coordinator.py Outdated
Comment thread tests/components/shelly/test_config_flow.py Outdated
Comment thread tests/components/shelly/test_config_flow.py Outdated
Comment thread tests/components/shelly/test_config_flow.py
Comment thread tests/components/shelly/test_config_flow.py
Copilot AI review requested due to automatic review settings April 27, 2026 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@frenck frenck merged commit d590f4f into dev Apr 27, 2026
37 checks passed
@frenck frenck deleted the epenet/20260427-1745 branch April 27, 2026 16:16
@epenet epenet mentioned this pull request Apr 28, 2026
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed code-owner-approved has-tests integration: shelly Quality Scale: platinum small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants