Require local_only to be a boolean on webhook#169296
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the webhook registration API by enforcing that local_only must be a real boolean, removing the legacy None behavior and its associated deprecation path.
Changes:
- Change
async_register(..., local_only=...)type contract frombool | Nonetobooland enforce it at runtime with aTypeError. - Remove the
local_only=Nonedeprecation/warning behavior during webhook handling and treatlocal_onlyas a strict boolean.
Co-authored-by: Copilot <copilot@github.com>
MartinHjelmare
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The
local_onlyargument onasync_registerfor webhooks needs to be abooleanProposed change
Removed deprecation of the
local_onlyargument in webhooks to be not a booleanType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: