Reduce image logbook spam#169289
Conversation
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR updates Home Assistant’s Logbook filtering rules so the image domain is treated as a continuous/high-churn domain, reducing user-facing Activity/Logbook noise from frequently-updating image entities (e.g., Roborock map images).
Changes:
- Add
imageto Logbook’sALWAYS_CONTINUOUS_DOMAINSto suppress high-frequency image state changes from appearing as logbook activity. - Update the inline comment to reflect the expanded hard-coded domain list.
| # the entire counter, image, and proximity integrations | ||
| # to get the name of the domain. | ||
| ALWAYS_CONTINUOUS_DOMAINS = {"counter", "proximity"} | ||
| ALWAYS_CONTINUOUS_DOMAINS = { | ||
| "counter", | ||
| "image", | ||
| "proximity", | ||
| } |
There was a problem hiding this comment.
Add/adjust logbook tests to cover the new behavior that image entities are treated as always-continuous and therefore excluded from logbook output/streams. The logbook component already has coverage for other always-continuous domains (e.g., counter/proximity), so extending those tests (e.g., tests/components/logbook/test_init.py::test_filter_continuous_sensor_values and/or websocket stream tests) to include an image.* entity would prevent regressions.
|
Duplicate of #169240 |
Proposed change
Treat the
imagedomain as a continuous/high-churn domain in logbook filtering.Roborock map image entities can update frequently during cleaning, which can cause repeated Activity/Logbook entries even though the updates are expected behavior.
This keeps the image entity state updates intact, but avoids surfacing those high-frequency image updates as user-facing logbook activity.
Type of change
Additional information
Checklist