Skip to content

Reduce image logbook spam#169289

Closed
rotempasharel1 wants to merge 1 commit into
home-assistant:devfrom
rotempasharel1:fix-roborock-image-logbook-spam
Closed

Reduce image logbook spam#169289
rotempasharel1 wants to merge 1 commit into
home-assistant:devfrom
rotempasharel1:fix-roborock-image-logbook-spam

Conversation

@rotempasharel1
Copy link
Copy Markdown

@rotempasharel1 rotempasharel1 commented Apr 27, 2026

Proposed change

Treat the image domain as a continuous/high-churn domain in logbook filtering.

Roborock map image entities can update frequently during cleaning, which can cause repeated Activity/Logbook entries even though the updates are expected behavior.

This keeps the image entity state updates intact, but avoids surfacing those high-frequency image updates as user-facing logbook activity.

Type of change

  • Bugfix
  • New integration
  • New feature
  • Dependency upgrade
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.

Copilot AI review requested due to automatic review settings April 27, 2026 13:29
@rotempasharel1 rotempasharel1 requested a review from a team as a code owner April 27, 2026 13:29
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rotempasharel1

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot marked this pull request as draft April 27, 2026 13:29
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of logbook can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign logbook Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Home Assistant’s Logbook filtering rules so the image domain is treated as a continuous/high-churn domain, reducing user-facing Activity/Logbook noise from frequently-updating image entities (e.g., Roborock map images).

Changes:

  • Add image to Logbook’s ALWAYS_CONTINUOUS_DOMAINS to suppress high-frequency image state changes from appearing as logbook activity.
  • Update the inline comment to reflect the expanded hard-coded domain list.

Comment on lines +14 to +20
# the entire counter, image, and proximity integrations
# to get the name of the domain.
ALWAYS_CONTINUOUS_DOMAINS = {"counter", "proximity"}
ALWAYS_CONTINUOUS_DOMAINS = {
"counter",
"image",
"proximity",
}
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/adjust logbook tests to cover the new behavior that image entities are treated as always-continuous and therefore excluded from logbook output/streams. The logbook component already has coverage for other always-continuous domains (e.g., counter/proximity), so extending those tests (e.g., tests/components/logbook/test_init.py::test_filter_continuous_sensor_values and/or websocket stream tests) to include an image.* entity would prevent regressions.

Copilot uses AI. Check for mistakes.
@MartinHjelmare
Copy link
Copy Markdown
Member

Duplicate of #169240

@MartinHjelmare MartinHjelmare marked this as a duplicate of #169240 Apr 27, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock integration spams Activity with frequent map update state changes during cleaning

3 participants