Skip to content

Fix logbook spam by including image domain in ALWAYS_CONTINUOUS_DOMAINS #169240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 4 commits into from
Apr 29, 2026
Merged

Fix logbook spam by including image domain in ALWAYS_CONTINUOUS_DOMAINS #169240

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daac4a8
fix(logbook): add image domain to ALWAYS_CONTINUOUS_DOMAINS
daily063 Apr 24, 2026
cbf7411
address copilot and maintainer review comments
daily063 Apr 28, 2026
caffbbb
Fix CI: restore trailing newline and remove broken tests
daily063 Apr 28, 2026
0a01aa0
Merge branch 'dev' into fix-issue-161039
MartinHjelmare Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/logbook/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
# Domains that are always continuous
#
# These are hard coded here to avoid importing
# the entire counter and proximity integrations
# the entire counter, image, and proximity integrations
# to get the name of the domain.
ALWAYS_CONTINUOUS_DOMAINS = {"counter", "proximity"}
ALWAYS_CONTINUOUS_DOMAINS = {"counter", "image", "proximity"}
Comment thread
MartinHjelmare marked this conversation as resolved.

# Domains that are continuous if there is a UOM set on the entity
CONDITIONALLY_CONTINUOUS_DOMAINS = {SENSOR_DOMAIN}
Expand Down
11 changes: 9 additions & 2 deletions tests/components/logbook/test_websocket_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2559,6 +2559,7 @@ def _cycle_entities():
entity_id, state, {ATTR_UNIT_OF_MEASUREMENT: "any"}
)
hass.states.async_set("counter.any", state)
hass.states.async_set("image.any", state)
hass.states.async_set("proximity.any", state)

# We will compare event subscriptions after closing the websocket connection,
Expand All @@ -2573,7 +2574,7 @@ def _cycle_entities():
"id": 7,
"type": "logbook/event_stream",
"start_time": now.isoformat(),
"entity_ids": ["sensor.uom", "counter.any", "proximity.any"],
"entity_ids": ["sensor.uom", "counter.any", "image.any", "proximity.any"],
}
)

Expand Down Expand Up @@ -2908,6 +2909,7 @@ def _create_events():
entity_id, state, {ATTR_UNIT_OF_MEASUREMENT: "any"}
)
hass.states.async_set("counter.any", state)
hass.states.async_set("image.any", state)
hass.states.async_set("proximity.any", state)
hass.bus.async_fire("mock_event", {"device_id": device.id})
hass.bus.async_fire("mock_event", {"device_id": device2.id})
Expand All @@ -2924,7 +2926,7 @@ def _create_events():
"id": 7,
"type": "logbook/event_stream",
"start_time": now.isoformat(),
"entity_ids": ["sensor.uom", "counter.any", "proximity.any"],
"entity_ids": ["sensor.uom", "counter.any", "image.any", "proximity.any"],
"device_ids": [device.id, device2.id],
}
)
Expand Down Expand Up @@ -3113,6 +3115,11 @@ def auto_off_listener(event):
{},
0, # Counter is an always continuous domain
),
(
"image.map0",
{},
0, # Image is an always continuous domain
),
(
"zone.home",
{},
Expand Down
Loading