Skip to content

Remove TARGET_TEMPERATURE_RANGE from eurotronic climate#169182

Merged
joostlek merged 2 commits into
home-assistant:devfrom
rikroe:eurotronic-cometblue-climate-highlow
Apr 26, 2026
Merged

Remove TARGET_TEMPERATURE_RANGE from eurotronic climate#169182
joostlek merged 2 commits into
home-assistant:devfrom
rikroe:eurotronic-cometblue-climate-highlow

Conversation

@rikroe
Copy link
Copy Markdown
Contributor

@rikroe rikroe commented Apr 26, 2026

Proposed change

Remove ClimateEntityFeature.TARGET_TEMPERATURE_RANGE from eurotronic cometblue climate.
Being a radiator valve, it doesn't fit the intended use of this feature.

See Discord discussion for more info.

No deprecation needed because this integration's first release will be 2026.5.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: not needed, was not documented before
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Eurotronic Comet Blue climate entity to no longer advertise (or snapshot) ClimateEntityFeature.TARGET_TEMPERATURE_RANGE, aligning the entity’s capabilities with a radiator valve’s intended usage in Home Assistant.

Changes:

  • Remove TARGET_TEMPERATURE_RANGE from the entity’s supported_features.
  • Stop exposing target_temp_high / target_temp_low in the entity snapshot/state by removing the range feature.
  • Rename the internal high/low temperature accessors used for preset detection to avoid implementing the range API.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/eurotronic_cometblue/climate.py Removes the range feature flag and switches preset logic to internal (non-range) temperature helpers.
tests/components/eurotronic_cometblue/snapshots/test_climate.ambr Updates expected snapshot to reflect the removed feature and removed target temp high/low attributes.
Comments suppressed due to low confidence (1)

homeassistant/components/eurotronic_cometblue/climate.py:62

  • Remove or explicitly reject handling of target temperature range service fields now that the entity no longer advertises TARGET_TEMPERATURE_RANGE, to avoid exposing an undocumented API where callers can still pass target_temp_low/high and change device setpoints without state attributes reflecting it.
    _attr_supported_features: ClimateEntityFeature = (
        ClimateEntityFeature.TARGET_TEMPERATURE
        | ClimateEntityFeature.PRESET_MODE
        | ClimateEntityFeature.TURN_ON
        | ClimateEntityFeature.TURN_OFF
    )

Comment thread homeassistant/components/eurotronic_cometblue/climate.py Outdated
Comment thread homeassistant/components/eurotronic_cometblue/climate.py Outdated
@joostlek joostlek merged commit a506be4 into home-assistant:dev Apr 26, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants