Remove TARGET_TEMPERATURE_RANGE from eurotronic climate#169182
Merged
joostlek merged 2 commits intoApr 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Eurotronic Comet Blue climate entity to no longer advertise (or snapshot) ClimateEntityFeature.TARGET_TEMPERATURE_RANGE, aligning the entity’s capabilities with a radiator valve’s intended usage in Home Assistant.
Changes:
- Remove
TARGET_TEMPERATURE_RANGEfrom the entity’ssupported_features. - Stop exposing
target_temp_high/target_temp_lowin the entity snapshot/state by removing the range feature. - Rename the internal high/low temperature accessors used for preset detection to avoid implementing the range API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/eurotronic_cometblue/climate.py |
Removes the range feature flag and switches preset logic to internal (non-range) temperature helpers. |
tests/components/eurotronic_cometblue/snapshots/test_climate.ambr |
Updates expected snapshot to reflect the removed feature and removed target temp high/low attributes. |
Comments suppressed due to low confidence (1)
homeassistant/components/eurotronic_cometblue/climate.py:62
- Remove or explicitly reject handling of target temperature range service fields now that the entity no longer advertises TARGET_TEMPERATURE_RANGE, to avoid exposing an undocumented API where callers can still pass target_temp_low/high and change device setpoints without state attributes reflecting it.
_attr_supported_features: ClimateEntityFeature = (
ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.PRESET_MODE
| ClimateEntityFeature.TURN_ON
| ClimateEntityFeature.TURN_OFF
)
21 tasks
joostlek
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove
ClimateEntityFeature.TARGET_TEMPERATURE_RANGEfrom eurotronic cometblue climate.Being a radiator valve, it doesn't fit the intended use of this feature.
See Discord discussion for more info.
No deprecation needed because this integration's first release will be 2026.5.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: