Add number platform to Fumis integration#169100
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new number platform to the Fumis integration so users can control stove power level and (optionally) fan speed via Home Assistant number entities.
Changes:
- Add
numberplatform entities forpower_level(1–5) andfan_speed(0–5, disabled by default). - Register new entity strings and icons for the number entities.
- Add comprehensive tests + snapshots covering entity creation, defaults, service calls, error handling, and conditional creation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/fumis/init.py | Adds Platform.NUMBER to the config entry forwarded platforms. |
| homeassistant/components/fumis/number.py | Implements the two number entities backed by the coordinator/client. |
| homeassistant/components/fumis/strings.json | Adds translated entity names for the new number entities. |
| homeassistant/components/fumis/icons.json | Adds default icons for the new number entities. |
| tests/components/fumis/test_number.py | Adds tests for registry behavior, service calls, exception handling, and conditional creation. |
| tests/components/fumis/snapshots/test_number.ambr | Snapshot coverage for number entity registry entries and states. |
| tests/components/fumis/const.py | Shared test constant for the config entry unique ID. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
joostlek
left a comment
There was a problem hiding this comment.
This PR now contains a merge conflict and has the button platform as well
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
c5f208b to
4204b71
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a Number platform to the Home Assistant Fumis integration, exposing additional controllable settings as entities (in addition to the existing sensors/climate/button support).
Changes:
- Add
number.pywith two number entities: power_level (1–5) and fan_speed (0–5, disabled by default and only created when supported). - Extend Fumis integration metadata to include Number platform setup plus entity translations and icons.
- Add snapshot- and behavior-based tests for the new number entities (including disabled-by-default and conditional creation).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/fumis/__init__.py |
Adds Platform.NUMBER so config entries forward setup to the new number platform. |
homeassistant/components/fumis/number.py |
Implements the two NumberEntity controls and wires them to the Fumis client + coordinator refresh. |
homeassistant/components/fumis/strings.json |
Adds translation strings for the new number entities. |
homeassistant/components/fumis/icons.json |
Adds icons for the new number entities. |
tests/components/fumis/test_number.py |
Adds tests for entity setup/snapshots, service calls, error handling, disabled-by-default, and conditional creation. |
tests/components/fumis/snapshots/test_number.ambr |
Adds snapshot coverage for the new number entities. |
Proposed change
Add a number platform to the Fumis integration with two entities:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: