Skip to content

Add number platform to Fumis integration#169100

Merged
edenhaus merged 2 commits into
devfrom
frenck-2026-0433
Apr 29, 2026
Merged

Add number platform to Fumis integration#169100
edenhaus merged 2 commits into
devfrom
frenck-2026-0433

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 24, 2026

Proposed change

Add a number platform to the Fumis integration with two entities:

  • Power level: Set the stove's power level from 1 to 5. This is a primary control that directly affects how much heat the stove produces.
  • Fan speed: Adjust the fan speed from 0 to 5. Disabled by default as this is an advanced setting that most users should not need to change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new number platform to the Fumis integration so users can control stove power level and (optionally) fan speed via Home Assistant number entities.

Changes:

  • Add number platform entities for power_level (1–5) and fan_speed (0–5, disabled by default).
  • Register new entity strings and icons for the number entities.
  • Add comprehensive tests + snapshots covering entity creation, defaults, service calls, error handling, and conditional creation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/fumis/init.py Adds Platform.NUMBER to the config entry forwarded platforms.
homeassistant/components/fumis/number.py Implements the two number entities backed by the coordinator/client.
homeassistant/components/fumis/strings.json Adds translated entity names for the new number entities.
homeassistant/components/fumis/icons.json Adds default icons for the new number entities.
tests/components/fumis/test_number.py Adds tests for registry behavior, service calls, exception handling, and conditional creation.
tests/components/fumis/snapshots/test_number.ambr Snapshot coverage for number entity registry entries and states.
tests/components/fumis/const.py Shared test constant for the config entry unique ID.

@frenck frenck marked this pull request as ready for review April 24, 2026 20:10
@frenck

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now contains a merge conflict and has the button platform as well

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft April 26, 2026 12:16
@frenck

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings April 27, 2026 10:16
@frenck frenck review requested due to automatic review settings April 27, 2026 10:16

This comment was marked as resolved.

@frenck frenck force-pushed the frenck-2026-0433 branch from c5f208b to 4204b71 Compare April 27, 2026 10:31
Copilot AI review requested due to automatic review settings April 27, 2026 10:31
@frenck frenck marked this pull request as ready for review April 27, 2026 10:32
@home-assistant home-assistant Bot requested a review from joostlek April 27, 2026 10:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Number platform to the Home Assistant Fumis integration, exposing additional controllable settings as entities (in addition to the existing sensors/climate/button support).

Changes:

  • Add number.py with two number entities: power_level (1–5) and fan_speed (0–5, disabled by default and only created when supported).
  • Extend Fumis integration metadata to include Number platform setup plus entity translations and icons.
  • Add snapshot- and behavior-based tests for the new number entities (including disabled-by-default and conditional creation).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/fumis/__init__.py Adds Platform.NUMBER so config entries forward setup to the new number platform.
homeassistant/components/fumis/number.py Implements the two NumberEntity controls and wires them to the Fumis client + coordinator refresh.
homeassistant/components/fumis/strings.json Adds translation strings for the new number entities.
homeassistant/components/fumis/icons.json Adds icons for the new number entities.
tests/components/fumis/test_number.py Adds tests for entity setup/snapshots, service calls, error handling, disabled-by-default, and conditional creation.
tests/components/fumis/snapshots/test_number.ambr Adds snapshot coverage for the new number entities.

Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frenck 👍

@edenhaus edenhaus merged commit 05bfb3a into dev Apr 29, 2026
33 checks passed
@edenhaus edenhaus deleted the frenck-2026-0433 branch April 29, 2026 07:39
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants