Skip to content

Use new UPTIME sensor class for Shelly#169088

Merged
frenck merged 1 commit into
home-assistant:devfrom
chemelli74:chemelli74-uptime-shelly
Apr 24, 2026
Merged

Use new UPTIME sensor class for Shelly#169088
frenck merged 1 commit into
home-assistant:devfrom
chemelli74:chemelli74-uptime-shelly

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

Proposed change

Use new UPTIME sensor class for Shelly

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 added this to the 2026.5.0b0 milestone Apr 24, 2026
Copilot AI review requested due to automatic review settings April 24, 2026 17:36
@home-assistant home-assistant Bot added cla-signed code-quality has-tests integration: shelly small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 24, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Shelly integration’s “Last restart” sensors to use Home Assistant’s new SensorDeviceClass.UPTIME so core can handle small drift/variance consistently.

Changes:

  • Switch Shelly “Last restart” sensors from SensorDeviceClass.TIMESTAMP to SensorDeviceClass.UPTIME.
  • Remove the Shelly-specific uptime drift helper (get_device_uptime) and its UPTIME_DEVIATION constant.
  • Update Shelly device snapshots to reflect the new sensor device class.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/shelly/sensor.py Uses SensorDeviceClass.UPTIME and computes last restart from utcnow() - timedelta(seconds=uptime) for REST/RPC sensors.
homeassistant/components/shelly/utils.py Removes the no-longer-needed get_device_uptime helper and related imports.
homeassistant/components/shelly/const.py Removes UPTIME_DEVIATION constant since drift handling is now in core’s UPTIME device class normalization.
tests/components/shelly/test_utils.py Drops the unit test for the removed helper and cleans up unused imports.
tests/components/shelly/snapshots/test_devices.ambr Updates snapshot expectations from timestamp to uptime device class.

Copy link
Copy Markdown
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abmantis
Copy link
Copy Markdown
Member

Should we mark this as a braking change? Users may have templates using the device_class attr

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 24, 2026

Should we mark this as a braking change? Users may have templates using the device_class attr

I honestly think this one is fine to ship like this 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 1e0dc86 into home-assistant:dev Apr 24, 2026
37 checks passed
@chemelli74 chemelli74 deleted the chemelli74-uptime-shelly branch April 24, 2026 18:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed code-quality has-tests integration: shelly Quality Scale: platinum small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants