Skip to content

Disable knx tests broken by Python 3.14.3 asyncio changes#169079

Merged
abmantis merged 1 commit into
devfrom
disable-py3143-flaky-tests-knx
Apr 24, 2026
Merged

Disable knx tests broken by Python 3.14.3 asyncio changes#169079
abmantis merged 1 commit into
devfrom
disable-py3143-flaky-tests-knx

Conversation

@justanotherariel
Copy link
Copy Markdown
Member

@justanotherariel justanotherariel commented Apr 24, 2026

Breaking change

Proposed change

Disable flaky knx tests that fail due to the Python 3.14.3 asyncio executor scheduling change (#162263).

The following tests are affected:

  • tests/components/knx/test_sensor.py::test_sensor_restore

These tests are skipped with @pytest.mark.xfail until codeowners can address the underlying timing issue. A tracking issue has been created for this: #169081.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables a flaky KNX sensor restore test that started failing after the Python 3.14.3 asyncio executor scheduling change, to keep CI stable until the underlying timing issue is fixed.

Changes:

  • Marks test_sensor_restore in the KNX sensor test suite as an expected failure due to Python 3.14.3 asyncio behavior changes.

Comment on lines +65 to +67
@pytest.mark.xfail(
reason="Flaky due to Python 3.14.3 asyncio changes - see home-assistant/core#162263"
)
Copy link
Copy Markdown
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abmantis abmantis merged commit 4d8acfa into dev Apr 24, 2026
37 checks passed
@abmantis abmantis deleted the disable-py3143-flaky-tests-knx branch April 24, 2026 17:54
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants